Fix #65 Support multiple directives in symbols

Signed-off-by: Remy Suen <[email protected]>
rcjsuen · Mar 27, 2020 · 38fd898 · 38fd898
1 parent 0b8986f
commit 38fd898
Show file tree

Hide file tree

Showing 3 changed files with 223 additions and 176 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,10 @@
 # Changelog
 All notable changes to this project will be documented in this file.
 
+## [Unreleased]
+### Added
+- support multiple directives when calculating a Dockerfile's symbols ([#65](https://github.com/rcjsuen/dockerfile-language-service/issues/65))
+
 ## [0.0.10] - 2020-03-25
 ### Added
 - all tokens are now assigned a semantic meaning for the experimental support of semantic tokens ([#54](https://github.com/rcjsuen/dockerfile-language-service/issues/54))
@@ -278,6 +282,7 @@ let workspaceEdit = {
     - textDocument/rename
     - textDocument/hover
 
+[Unreleased]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.10...HEAD
 [0.0.10]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.9...v0.0.10
 [0.0.9]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.8...v0.0.9
 [0.0.8]: https://github.com/rcjsuen/dockerfile-language-service/compare/v0.0.7...v0.0.8

diff --git a/src/dockerSymbols.ts b/src/dockerSymbols.ts
@@ -33,9 +33,8 @@ export class DockerSymbols {
 
     public parseSymbolInformation(textDocument: TextDocumentIdentifier, content: string): SymbolInformation[] {
         let dockerfile = DockerfileParser.parse(content);
-        let directive = dockerfile.getDirective();
         let symbols: SymbolInformation[] = [];
-        if (directive !== null) {
+        for (const directive of dockerfile.getDirectives()) {
             symbols.push(this.createSymbolInformation(directive.getName(), textDocument.uri, directive.getNameRange(), SymbolKind.Property, false));
         }
         for (let instruction of dockerfile.getInstructions()) {