Skip to content

Commit

Permalink
Fix #64 Use plain text for signature labels
Browse files Browse the repository at this point in the history
The escape parser directive's signature label was incorrectly formatted
in Markdown instead of plain text.

Signed-off-by: Remy Suen <[email protected]>
  • Loading branch information
rcjsuen committed Mar 13, 2020
1 parent a0f732b commit 0e03687
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ All notable changes to this project will be documented in this file.
- allow hovers to be displayed for instruction keywords that span multiple lines ([#59](https://github.com/rcjsuen/dockerfile-language-service/issues/59))
- correct hover resolution of a variable if it comes after a false comment in a multiline instruction ([#61](https://github.com/rcjsuen/dockerfile-language-service/issues/61))
- correct hover resolution of a variable that comes after an embedded comment with a trailing escape character in a multiline instruction ([#62](https://github.com/rcjsuen/dockerfile-language-service/issues/62))
- use plain text instead of Markdown content for the signature label of the escape parser directive ([#64](https://github.com/rcjsuen/dockerfile-language-service/issues/64))

## [0.0.9] - 2020-02-12
### Added
Expand Down
2 changes: 1 addition & 1 deletion src/dockerSignatures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class DockerSignatures {
return {
signatures: [
{
label: "escape=`\\`",
label: "escape=\\",
documentation: this.documentation.getDocumentation("signatureEscape"),
parameters: [
{
Expand Down
2 changes: 1 addition & 1 deletion test/dockerSignatures.tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ function assertEscape(signatureHelp: SignatureHelp) {
assert.equal(signatureHelp.activeSignature, 0);
assert.equal(signatureHelp.activeParameter, 0);
assert.equal(signatureHelp.signatures.length, 1);
assert.equal(signatureHelp.signatures[0].label, "escape=`\\`");
assert.equal(signatureHelp.signatures[0].label, "escape=\\");
assert.notEqual(signatureHelp.signatures[0].documentation, null);
assert.equal(signatureHelp.signatures[0].documentation, docs.getDocumentation("signatureEscape"));
assert.equal(signatureHelp.signatures[0].parameters.length, 1);
Expand Down

0 comments on commit 0e03687

Please sign in to comment.