Invalid error after editing Dockerfile caused by incorrect handling of changes from textDocument/didChange

[chrisdias]

I'm testing the Docker extension for release, with 0.0.14 of the server.

Create this dockerfile:

FROM openjdk:8-jdk-alpine
VOLUME /tmp
ARG JAVA_OPTS
ENV JAVA_OPTS=$JAVA_OPTS
ADD stickerapp.jar stickerapp.jar
EXPOSE 3000
ENTRYPOINT exec java $JAVA_OPTS -jar stickerapp.jar
# For Spring-Boot project, use the entrypoint below to reduce Tomcat startup time.
#ENTRYPOINT exec java $JAVA_OPTS -Djava.security.egd=file:/dev/./urandom -jar stickerapp.jar

Put the cursor at the end of the line VOLUME /tmp and press backspace to delete /tmp
Press CMD+Z to undo your change so the line says VOLUME /tmp again.

Result: Red squiggles. Hover over ARG and see Invalid error [dockerfile-utils] Unknown instruction: /tmpARG

[rcjsuen]

Interesting. Thank you for the bug report, @chrisdias. I might not be able to look at it for a while pending hotel wifi...

[chrisdias]

looks like this is in 0.0.13 as well.

[rcjsuen]

I couldn't reproduce this with the current version of the online editor. I guess that makes sense. It must be something to do with VS Code instead of Monaco.

[rcjsuen]

I was able to reproduce this problem. Interestingly enough, I received two events when I initiated the undo with the second being an empty array...

{
  "textDocument": {
    "uri": "file:///blah/blah/Dockerfile",
    "version": 9
  },
  "contentChanges": [
    {
      "range": {
        "start": {
          "line": 1,
          "character": 7
        },
        "end": {
          "line": 1,
          "character": 7
        }
      },
      "rangeLength": 0,
      "text": "/"
    },
    {
      "range": {
        "start": {
          "line": 1,
          "character": 8
        },
        "end": {
          "line": 1,
          "character": 8
        }
      },
      "rangeLength": 0,
      "text": "t"
    },
    {
      "range": {
        "start": {
          "line": 1,
          "character": 9
        },
        "end": {
          "line": 1,
          "character": 9
        }
      },
      "rangeLength": 0,
      "text": "m"
    },
    {
      "range": {
        "start": {
          "line": 1,
          "character": 10
        },
        "end": {
          "line": 1,
          "character": 10
        }
      },
      "rangeLength": 0,
      "text": "p"
    }
  ]
}

{
  "textDocument": {
    "uri": "file:///blah/blah/Dockerfile",
    "version": 9
  },
  "contentChanges": []
}

[rcjsuen]

This is caused by the fix for #58. It seems like we'll need to figure out how to merge and sort the received contentChanges better.

[rcjsuen]

This is caused by the fix for #58. It seems like we'll need to figure out how to merge and sort the received contentChanges better.

Actually, I think I've just been misinterpreting the specification this whole time. I've always applied the changes in reverse order but I don't remember why. However, given that the specification states:

	/**
	 * The actual content changes. The content changes describe single state changes
	 * to the document. So if there are two content changes c1 and c2 for a document
	 * in state S10 then c1 move the document to S11 and c2 to S12.
	 */
	contentChanges: TextDocumentContentChangeEvent[];

It does sound like the changes should just be applied in the order it appears in the notification.

[rcjsuen]

@chrisdias Thanks again for the bug report! I've fixed the bug now and it will be included in the next release!