Skip to content

Commit

Permalink
WIP #134 Use actual file for docker-langserver binary
Browse files Browse the repository at this point in the history
It seems that referencing the server.js directly in package.json does
not appear to pass on the arguments on the command line to the
script. As other Node.js projects that uses a binary seems to
explicitly create a separate script for the launching of an
executable, we have done the same and created a bin/docker-langserver
file to startup lib/server.js.

Signed-off-by: Remy Suen <[email protected]>
  • Loading branch information
rcjsuen committed Aug 6, 2017
1 parent 0f6f143 commit b97c57a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
All notable changes to this project will be documented in this file.

## [Unreleased]
### Fixed
- created actual docker-langserver file instead of referencing server.js ([#134](https://github.com/rcjsuen/dockerfile-language-server-nodejs/issues/134))

## [0.0.3] - 2017-08-06
### Added
Expand Down
6 changes: 6 additions & 0 deletions bin/docker-langserver
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env node
/* --------------------------------------------------------------------------------------------
* Copyright (c) Remy Suen. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
* ------------------------------------------------------------------------------------------ */
require("../lib/server");
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"nyc": "^11.0.2"
},
"bin": {
"docker-langserver": "./lib/server.js"
"docker-langserver": "./bin/docker-langserver"
},
"scripts": {
"build": "tsc -p .",
Expand Down

0 comments on commit b97c57a

Please sign in to comment.