Fix #228 Warn if WORKDIR is not an absolute path

Docker suggests using absolute paths for WORKDIR instructions for clarity and reliability. A diagnostic will now be published if a WORKDIR instruction does not appear to be an absolute path. Signed-off-by: Remy Suen <[email protected]>
rcjsuen · Aug 19, 2018 · 0aaab39 · 0aaab39
1 parent 7339d61
commit 0aaab39
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 15 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
   - return code action literals if the client supports it ([#225](https://github.com/rcjsuen/dockerfile-language-server-nodejs/issues/225))
 - textDocument/publishDiagnostics
   - add support for SCTP in EXPOSE instruction ([rcjsuen/dockerfile-utils#52](https://github.com/rcjsuen/dockerfile-utils/issues/52))
+  - warn if WORKDIR is not an absolute path ([#228](https://github.com/rcjsuen/dockerfile-language-server-nodejs/issues/228))
 
 ### Changed
 - [upgraded the dependency of Mocha](https://github.com/mochajs/mocha/issues/2791) from 3.x to 5.x

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -21,7 +21,7 @@
   },
   "dependencies": {
     "dockerfile-language-service": "0.0.6",
-    "dockerfile-utils": "0.0.8",
+    "dockerfile-utils": "0.0.11",
     "vscode-languageserver": "^4.4.0"
   },
   "devDependencies": {

diff --git a/src/server.ts b/src/server.ts
@@ -226,6 +226,7 @@ function convertValidatorConfiguration(config: ValidatorConfiguration): Validato
 	let instructionEntrypointMultiple = ValidationSeverity.WARNING;
 	let instructionHealthcheckMultiple = ValidationSeverity.WARNING;
 	let instructionJSONInSingleQuotes = ValidationSeverity.WARNING;
+	let instructionWorkdirRelative = ValidationSeverity.WARNING;
 	if (config) {
 		deprecatedMaintainer = getSeverity(config.deprecatedMaintainer);
 		directiveCasing = getSeverity(config.directiveCasing);
@@ -235,6 +236,7 @@ function convertValidatorConfiguration(config: ValidatorConfiguration): Validato
 		instructionEntrypointMultiple = getSeverity(config.instructionEntrypointMultiple);
 		instructionHealthcheckMultiple = getSeverity(config.instructionHealthcheckMultiple);
 		instructionJSONInSingleQuotes = getSeverity(config.instructionJSONInSingleQuotes);
+		instructionWorkdirRelative = getSeverity(config.instructionWorkdirRelative);
 	}
 	return {
 		deprecatedMaintainer,
@@ -244,7 +246,8 @@ function convertValidatorConfiguration(config: ValidatorConfiguration): Validato
 		instructionCmdMultiple,
 		instructionEntrypointMultiple,
 		instructionHealthcheckMultiple,
-		instructionJSONInSingleQuotes
+		instructionJSONInSingleQuotes,
+		instructionWorkdirRelative
 	};
 }
 
@@ -269,7 +272,8 @@ interface ValidatorConfiguration {
 	instructionCmdMultiple?: string,
 	instructionEntrypointMultiple?: string,
 	instructionHealthcheckMultiple?: string,
-	instructionJSONInSingleQuotes?: string
+	instructionJSONInSingleQuotes?: string,
+	instructionWorkdirRelative?: string
 }
 
 interface Settings {