Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 Support #15

Closed
aogaili opened this issue Oct 6, 2017 · 8 comments
Closed

React 16 Support #15

aogaili opened this issue Oct 6, 2017 · 8 comments

Comments

@aogaili
Copy link

aogaili commented Oct 6, 2017

An older version of React is being loaded as a dependency:

"dependencies": {
"prop-types": "^15.5.10",
"react": "^15.6.1",
"react-dom": "^15.6.1"

I think it should be loaded as per dependency.

@rcdexta
Copy link
Owner

rcdexta commented Oct 6, 2017

Will fix it this weekend. Thanks for pointing out.

@aogaili
Copy link
Author

aogaili commented Oct 6, 2017

Thank you!

@rcdexta
Copy link
Owner

rcdexta commented Oct 8, 2017

Upgraded to React 16 now. If your parent application uses React 15.x, this should work too.. Please pull v1.3.5

@rcdexta rcdexta closed this as completed Oct 8, 2017
@rcdexta rcdexta reopened this Oct 8, 2017
@rcdexta
Copy link
Owner

rcdexta commented Oct 8, 2017

react and react-dom are peer dependencies now.. @aliogaili: Let me know if this works for you..

@rcdexta rcdexta closed this as completed Oct 8, 2017
@aogaili
Copy link
Author

aogaili commented Oct 8, 2017

Thanks @rcdexta it's working great now.

Just quick question, I noticed that the package.json doesn't have a version attribute. I'm assuming you're using tags to publish. Is there a reason behind this choice? because it's the first time I see this and do you've some resources where I learn more about it.

Thanks again for closing this issue.

@rcdexta
Copy link
Owner

rcdexta commented Oct 8, 2017

I use semantic versioning workflow to take care of version bumping based on whether it is a feature/fix being committed and you can look here for more info: https://github.com/semantic-release/semantic-release

@aogaili
Copy link
Author

aogaili commented Oct 8, 2017

Much appreciated, thanks @rcdexta

@aogaili
Copy link
Author

aogaili commented Oct 8, 2017

Wow this semantic versioning is amazing, the node ecosystem keep on surprising me everyday, lots of smart folks around :)

dreamjet31 pushed a commit to dreamjet31/react-event-timeline that referenced this issue Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants