Merge pull request #2 from octogonz/octogonz/deeplyLinkedTypes-fix

[api-extractor] Don't generate kind=Reference excerpt tokens when there is no reference
rbuckton · Sep 8, 2019 · 7b67d84 · 7b67d84
2 parents 86674a2 + 5851849
commit 7b67d84
Show file tree

Hide file tree

Showing 27 changed files with 514 additions and 1,451 deletions.
diff --git a/apps/api-extractor/src/generators/ExcerptBuilder.ts b/apps/api-extractor/src/generators/ExcerptBuilder.ts
@@ -117,11 +117,16 @@ export class ExcerptBuilder {
     }
 
     if (span.prefix) {
+      let canonicalReference: DeclarationReference | undefined = undefined;
+
       if (span.kind === ts.SyntaxKind.Identifier) {
         const name: ts.Identifier = span.node as ts.Identifier;
-        const canonicalReference: DeclarationReference | undefined = isDeclarationName(name)
-          ? undefined
-          : state.referenceGenerator.getDeclarationReferenceForIdentifier(name);
+        if (!isDeclarationName(name)) {
+          canonicalReference = state.referenceGenerator.getDeclarationReferenceForIdentifier(name);
+        }
+      }
+
+      if (canonicalReference) {
         ExcerptBuilder._appendToken(excerptTokens, ExcerptTokenKind.Reference,
           span.prefix, state, canonicalReference);
       } else {