Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when working with another polyfill, like core-js/reflect #78

Closed
k1r0s opened this issue Aug 7, 2017 · 1 comment
Closed

Error when working with another polyfill, like core-js/reflect #78

k1r0s opened this issue Aug 7, 2017 · 1 comment
Labels
Bug Fixed

Comments

@k1r0s
Copy link

k1r0s commented Aug 7, 2017

Angular2+ uses core-js/reflect as reflection utility. My library uses reflect-metadata.

Problem is this library overrides Reflect global object causing errors in Angular decorator factory API.

As you can see in the image below, overriding reflection global object can mess other libraries. Would be better solution check if that object is already defined before reasigning

image
@remojansen remojansen mentioned this issue Jan 4, 2018
Closed
rbuckton added a commit that referenced this issue Jan 16, 2018
@rbuckton
Do not clobber existing Reflect metadata polyfill. Fixes #80, #78
69f4359
@rbuckton
Copy link
Owner

Fixed in 69f4359

@terrybondy terrybondy mentioned this issue Aug 26, 2019
Open
@snyk-bot snyk-bot mentioned this issue Jan 3, 2020
Merged
This was referenced Mar 11, 2020
Open
Open
This was referenced Apr 7, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbuckton @k1r0s