Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match colors used in AddToCartBlink event to current color theme #563

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

qkeitoe
Copy link
Contributor

@qkeitoe qkeitoe commented Dec 12, 2024

Before:
before

After:
after

event AddToCartBlink
{
Animate CartButton bgcolor bh_Theme_BG20 Linear 0.0 0.01
Animate CartButton bgcolor bh_orange Linear 0.1 0.01
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these bh_orange entries want to be bh_Theme_TextAccent, since (in theory) this would be the accent color of the HUD that could be changed. Whether or not I will ever actually make themes is another story, but I've been using bh_Theme_TextAccent in place of bh_orange for that reason.

Copy link
Contributor Author

@qkeitoe qkeitoe Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I thought about using bh_Theme_TextAccent there, but in the end I decided to use another one because of Text in the name. I'll fix it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 557242c

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it has that name because I was originally going to have it more granularly controlled, but then I realize it didn't really make sense. Eventually I wanted to go through and change a handful of color definitions to be more in line, but I've vene delaying for a while

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 557242c

Perfect, thank you! I'm hoping I'll have time this weekend to get to a lot of these issues & PRs

@rbjaxter rbjaxter merged commit 0cb5a1f into rbjaxter:development Dec 14, 2024
@qkeitoe qkeitoe deleted the patch/AddToCartBlink branch December 14, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants