Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MVM & Arena fixes #495

Merged
merged 5 commits into from
Jul 4, 2024
Merged

MVM & Arena fixes #495

merged 5 commits into from
Jul 4, 2024

Conversation

Kruphixx
Copy link
Contributor

@Kruphixx Kruphixx commented Jul 4, 2024

Before:
20240704212639_1

After:
20240704212725_1

@Kruphixx
Copy link
Contributor Author

Kruphixx commented Jul 4, 2024

Also fixed server time overlapping arena player count.

Before:
20240704214044_1

After:
20240704214336_1

@Kruphixx Kruphixx changed the title Fixed MVM progress bar overlapping flag MVM & Arena fixes Jul 4, 2024
@rbjaxter
Copy link
Owner

rbjaxter commented Jul 4, 2024

Mostly looks good, though I wouldn't want to move ReinforcementsLabel, because it's meant to slot into this position when the scoreboard's open:
image

@Kruphixx
Copy link
Contributor Author

Kruphixx commented Jul 4, 2024

I can move it back but then it will continue overlapping, though maybe something else can be done in the future

@rbjaxter
Copy link
Owner

rbjaxter commented Jul 4, 2024

yeah tbh I may just remove that respawn note in chat_english if I can, not sure it's really necessary. the rest seems good though :)

@rbjaxter rbjaxter merged commit 25f44ff into rbjaxter:master Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kruphixx @rbjaxter