Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated bh_player_healthcross_inset.res and README links. #494

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Updated bh_player_healthcross_inset.res and README links. #494

merged 2 commits into from
Jul 4, 2024

Conversation

PeanutKarver
Copy link
Contributor

Updated bh_player_healthcross_inset.res for better visuals. Health cross background, overheal, and status effects align better with the health cross. Added pictures for a before and after comparison.

Before health cross background alignment change:
20240704000754_1
After health cross background alignment change:
20240704000806_1

Before status effect alignment change:
20240704001645_1
After status effect alignment change:
20240704001654_1
The status effects are misaligned to the health cross in the base game too, so you don't necessarily have to change this part.
20240704011308_1

Before overheal alignment change (Full overheal):
20240704001904_1
After overheal alignment change (Full overheal):
20240704001932_1

Before overheal alignment change (Minimum overheal):
20240704002241_1
After overheal alignment change (Minimum overheal):
20240704002303_1
The overheal changes were made specifically for minimum overheal. The larger image while fully overhealed is an unintended side-effect, but that should be fine.

I also tried updating some of the README links. Not sure if they're the right links, but I tried. I did that part on a whim.

Updated for better visuals. Health cross background, overheal, and status effects align better with the health cross.
Updated some of the links that were outdated. Wasn't my main intention while trying to contribute, so I'm not sure if I got it right.
@rbjaxter
Copy link
Owner

rbjaxter commented Jul 4, 2024

This looks good to me, and very thorough which I appreciate :) I can check this on my end, but did you happen to check it on another aspect ratio + resolution?

@rbjaxter
Copy link
Owner

rbjaxter commented Jul 4, 2024

I'll just check and correct if any issues, thanks for fixing this!

@rbjaxter rbjaxter merged commit e6f95bb into rbjaxter:master Jul 4, 2024
@PeanutKarver
Copy link
Contributor Author

Hey, sorry for the late reply. I know this closed, but I don't know where else to post this. I checked a few resolutions, and I noticed there were few problems I'd like to elaborate on. For reference, every image has addcond 58; addcond 59; addcond 60; addcond 48; addcond 30; addcond 93 enabled for a total of 6 status effects.

1600x900 (16:9)
20240705025222_1

1280x720 (16:9)
20240705025315_1

1280x800 (16:10)
20240706005807_1

720x480 (16:10)
20240706005846_1

800x600 (4:3)
20240705025356_1

640x480 (4:3)
20240705025434_1

640x480 (4:3) Old version
20240705024712_1
20240705024736_1

Firstly, the overheal and background health cross images have differing levels of quality, but I assume that's to be expected. However, I'd like to point out that the old image might have been created with the intent of being viewed in a 640x480 resolution. In that respect, it actually looks better than the new one I proposed in 4:3 resolutions (excluding at least 800x600 and 1152x864). It also has the benefit of looking similar to the default with its overheal. (I added 2 images for the old version, one with and without overheal, so that it's easier to spot the difference in overheal image)

Overheal Lowest

Also, I didn't notice this at first, but the new change separates it from having the near identical likeness as bh_player_m0re_healthcross_inset.res and the original m0rehud hudplayerhealth_cross_team.res.

When I originally made the change to bh_healthcross_inset.res, I created it under a 1600x900 resolution and without knowing that it had ties to different files. In a way, it might be better to revert the changes to bh_player_healthcross_inset.res if you prefer what the older one had in comparison to the new one, and I can just keep the change for myself. If you like it though, let me know if you want me to change bh_player_m0re_healthcross_inset.res to match the new change, and maybe I can create a pull request to m0rehud so that it's all uniform.

Second, there's a problem with the status effect images shifting depending on how low the game's resolution is set to. I checked, and this seems to be a problem with all hudplayerhealth.res files, including hudplayerhealth_cross_team.res in m0rehud and in the default hud. I'm not sure if there's anything to be done about it, but if you want to look into a fix, it seems like m0rehud is more resistant to the change. At least, for the first status effect.

1600x900 to 640x480
20240705050212_1
20240705061154_1

Since I was looking into mostly all the hudplayerhealth.res files in budhud to check if the status effect issue wasn't specific to bh_healthcross_inset.res, I noticed that all the ones I checked have their status effects a bit misaligned with the health in a 1600x900 resolution.

20240706015414_1

I could fix all of them, but I'd like to know what resolution budhud was originally created for. They're all a little to the left, so I get the feeling that it may be on purpose and something I shouldn't touch.

Lastly, while looking into all of this, I noticed that budhud shows up to a maximum of 3 status effects on a 1600x900 resolution. That's exactly how the default hud handles it, but on lower resolutions it starts to clip too early. I can fix it so that a monitor displays as many as it physically can by increasing the HudPlayerHealth wide property, but since it only extends the area right and the status effects are displayed right-to-left, it would require every hudplayerhealth.res to change their positioning. I'd like to know your opinion on whether or not you'd like a sizeable change like that. I also cannot ensure I can provide support to ultra-wide monitors, since my monitor only goes up to 1600x900 and anything outside of that is outside of my ability. If you don't want a change like that, I'd like to note that bh_player_healthcross.res and bh_player_m0re_healthcross.res have the clipping issue without applying a lower resolution.

1600x900
20240706022241_1

I think that's about it. Again, sorry for the late reply. It took a while to look into everything and make this write-up.

P.S. Since you're accepting visual changes like this, you should technically update budhud's imgur gallery. I don't imagine that's one of your top priorities, but I thought I'd add this just in case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants