-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell script improvement suggestions #550
Comments
For the first point, I'm a bit hesitant about it just because I have to imagine the compiler is already giving 99% of the performance benefits just from its initial pass of combining base directives. The only thing that flag would really be saving lines on are some "disabled by default" customization lines. I'm just not sure if the trade-off of the marginal performance gain outweighs the fact that they're stuck with whatever version of the hud they compiled (essentially). I suppose making it an option does allow someone to get the most pure-blooded non-#base-using-hud possible, but I just hope it wouldn't cause more confusion for those that use it. For the parent directory check, I think i need to take a closer look myself at how that check compares to Check_HUDFiles and perhaps combine them. I may redo all the checks to avoid redunancy and also clean up them a bit more. |
Removes broad script location check in favor of localizing checks into individual functions where needed also some minor changes to the compiler backup behavior
@qkeitoe Let me know if this change to the check works for what you're doing. hopefully should, it just checks for folders it needs |
Oh yeah, it works perfectly fine! Thanks! Sorry for not letting you know sooner. |
@qkeitoe That last commit adds a prompt for |
One minor note: I think it's better to prompt a user for the Line 892 in 6f605d4
|
Agreed, I'll change that in a future commit |
In essence, instead of hiding player names outright this will draw names as squares. Places where player names are shown solely show squares whereas places that have important numbers (TargetID for medic charge, etc) will show squares & numbers. Screenshots can be found in the GitHub issue that explain it better than I can #550
--omitMissingDirectives
. It seems to speed uphud_reloadscheme
a bit (on potato PCs). But on the other hand, this option breaks things if any HUD mods are installed outside of budhud (not sure if it's a common case). So, I would like to suggest asking a user before compiling if they want to enable this option or not (not sure about the default choice though).custom
, but I'd really appreciate it if it could again be possible to compile the HUD with no need to run the script fromtf/custom/<budhud folder name>/
.If you approve of any suggestions, I can potentially try to implement them (though I have barely any experience with powershell).
The text was updated successfully, but these errors were encountered: