feat(reset): set preview margins and paddings to 0 by default #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbardini
changed the title
|
I think it would be better to merge this one first, so users don't need to upgrade to a major version to have it. It might conflict with #10 though—I decided to use ranges in all example dependencies, so we always deploy with the latest supported versions. Is it ok for you? |
joanrm20
approved these changes
Dec 16, 2020
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storybook 6.1 introduces the
layoutparameter, set topaddedby default.This PR sets the preview margins and paddings to
0by default, so users are not required to change thelayoutoption tofullscreenwhen using the addon. It also ensures that both are reset in older Storybook versions, or when thenoneoption is used.