Rails 5.0+ Support (Drops Rails 4.2 Support) #192

joelvh · 2017-11-16T04:50:18Z

Upgraded CASino to support Rails 5.0+
Fixed tests
Addressed deprecations
Added Appraisals to test multiple versions of Rails
Dropped Rails 4.2 support because integration tests require keyword arguments and this isn't supported by Rails 4.2
Additional fixes

Please submit PRs to our branch for CASino maintenance: https://github.com/identification-io/CASino

Sometimes a login might require more information than just a username and password, in these cases the extra info can be pased to the authenticator via the context parameter as a Hash.

Add context

…ions

Require Rails 4.2+

…ons` doesn't work from Rails Engine

… deprecation warning that `table_exists?` will only check tables in Rails 5.1

… to blank strings: rails/rails#28129

…rationTest change AND potential security issues

…rails/rails#20666

… integration tests

Rails 5.x support (Dropped Rails 4.2 support)

coveralls · 2017-11-16T04:56:42Z

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T04:56:42Z

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T04:56:42Z

Coverage increased (+0.04%) to 97.236% when pulling f473af1 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:10:45Z

Coverage decreased (-0.1%) to 97.103% when pulling c233077 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:21:19Z

Coverage decreased (-0.1%) to 97.103% when pulling 2e989ae on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:21:19Z

Coverage decreased (-0.1%) to 97.103% when pulling 2e989ae on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:32:08Z

Coverage increased (+0.02%) to 97.226% when pulling 01cd1b4 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:32:08Z

Coverage increased (+0.02%) to 97.226% when pulling 01cd1b4 on identification-io:master into ff29323 on rbCAS:master.

coveralls · 2017-11-16T05:37:10Z

Coverage increased (+0.02%) to 97.226% when pulling 723dd0d on identification-io:master into ff29323 on rbCAS:master.

pencil · 2017-11-16T18:05:01Z

.travis.yml

+matrix:
+  allow_failures:
+    - rvm: 2.4.0
+    - rvm: 2.4.1


Why are there failures on 2.4.0 and 2.4.1? Seems slightly concerning.

@pencil something is causing the appraisal gem to not load properly on Travis to be able to run the tests - started looking into it, but not conclusive yet

pencil · 2017-11-16T18:05:52Z

CHANGELOG.md

@@ -0,0 +1,22 @@
+# 11/15/2017 - v5.0.0


We maintain the change log for CASino using GitHub's release page.

pencil · 2017-11-16T18:10:43Z

app/models/casino/application_record.rb

@@ -0,0 +1,3 @@
+class CASino::ApplicationRecord < ActiveRecord::Base


What's the advantage of using this class over ActiveRecord::Base directly?

@pencil Followed the Rails 5.0+ best practice. Also could serve as a better entry point for potential monkey-patching if needed.

dixalex · 2018-12-21T13:07:06Z

Hey folks. What's the status of this PR? Any luck it can be finished and merged some time soon?

abutterf · 2021-03-08T17:21:35Z

What's the status of this?

joelvh · 2021-03-09T00:35:57Z

@abutterf I don't think this gem is maintained anymore.

pencil · 2021-03-09T02:17:53Z

Yes, @joelvh is correct. I tried but failed to find someone to take over the project.

abutterf · 2021-03-09T15:19:14Z

Okay. Thanks for the info

meanphil and others added 30 commits March 15, 2017 20:35

Add context argument for an authenticator to use

0a36e48

Sometimes a login might require more information than just a username and password, in these cases the extra info can be pased to the authenticator via the context parameter as a Hash.

Created configurable authenticator context

e618b1c

Don't assume the context is a Hash

1305bab

Merge pull request #2 from identification-io/add_context

5a99dac

Add context

Added CHANGELOG.md

a724942

Fix deprecations and settings for Rails 4.2

c946cbe

Fix test that never should have worked - failed after fixing deprecat…

ba37677

…ions

Add testing for Ruby 2.4.0 and 2.4.1

9db91d9

Rubocop cleanup

47d685f

FactoryGirl is deprecated and replaced with FactoryBot (renamed)

30c6485

Loosen gem versioning

3a486e2

Ran bundle exec rake rails:update to upgrade to Rails 4.2 settings

1db1c00

Merge pull request #3 from identification-io/feature/rails42_upgrade

aae994e

Require Rails 4.2+

Version bump v4.2.0

75dfbe8

Updated CHANGELOG for v4.2.0

ce179ee

Implemented Appraisal tests for Rails 4.2, 5.0, and 5.1

e582de5

Don't explicitly set this option that is not available in Rails 5.x

f5b7732

Reference Rails Engine path (when mounted inside one)

32cd2ef

Copy migrations with a generator because `rake casino:install:migrati…

b78aa74

…ons` doesn't work from Rails Engine

Simplified adding namespace to paths

65d2192

Rails 5.0 deprecations fixed

3acb52e

Add extracted gem to fix failing tests

5aa6f5d

Updated lambda stynax

875a389

Use all scope for scope chaining instead of class

e0f9ec8

Updated RSpec version for specific Rails versions

8b4ddf4

Remove version constraint to allow for Rails 5.x

83c84ff

Add ApplicationRecord base class for models

53de3b7

Add migration version to migrations

93ae39b

Use data_source_exists? to check for tables and views - gets rid of…

df6f60d

… deprecation warning that `table_exists?` will only check tables in Rails 5.1

Set new option explicitly

7ce8f37

joelvh added 8 commits November 15, 2017 22:13

Fixing check for empty params - IntegrationTest converts nil params…

ef11cfc

… to blank strings: rails/rails#28129

Call super without implicit arguments

e748e1e

Invert logic

f0c6be1

Fix checks to look for blank values instead of nil to address Integ…

7b20d83

…rationTest change AND potential security issues

Explicitly respond with 406 status because this changed in Rails 5.0 - …

45bc718

…rails/rails#20666

Drop Rails 4.2 support - mainly because of keyword arguments in RSpec…

0781ba7

… integration tests

Version bump v5.0.0 (Rails 5.0+ support)

3cc12e8

Merge pull request #4 from identification-io/feature/rails5_upgrade

f473af1

Rails 5.x support (Dropped Rails 4.2 support)

joelvh mentioned this pull request Nov 16, 2017

Rails 5 support! #168

Open

Remove Rails 4.2 tests

c233077

Allow Ruby 2.4.x failures

2e989ae

joelvh added 2 commits November 16, 2017 00:26

Consolidate logic

01cd1b4

Updated CHANGELOG

723dd0d

pencil reviewed Nov 16, 2017

View reviewed changes

CHANGELOG.md

@@ -0,0 +1,22 @@

# 11/15/2017 - v5.0.0

Copy link

Member

pencil Nov 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We maintain the change log for CASino using GitHub's release page.

pencil reviewed Nov 16, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 5.0+ Support (Drops Rails 4.2 Support) #192

Rails 5.0+ Support (Drops Rails 4.2 Support) #192

joelvh commented Nov 16, 2017

coveralls commented Nov 16, 2017 •

edited

Loading

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017 •

edited

Loading

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017 •

edited

Loading

pencil Nov 16, 2017

joelvh Nov 16, 2017

pencil Nov 16, 2017

pencil Nov 16, 2017

joelvh Nov 16, 2017

dixalex commented Dec 21, 2018

abutterf commented Mar 8, 2021

joelvh commented Mar 9, 2021

pencil commented Mar 9, 2021

abutterf commented Mar 9, 2021

		@@ -0,0 +1,3 @@
		class CASino::ApplicationRecord < ActiveRecord::Base

Rails 5.0+ Support (Drops Rails 4.2 Support) #192

Are you sure you want to change the base?

Rails 5.0+ Support (Drops Rails 4.2 Support) #192

Conversation

joelvh commented Nov 16, 2017

coveralls commented Nov 16, 2017 • edited Loading

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017 • edited Loading

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017

coveralls commented Nov 16, 2017 • edited Loading

pencil Nov 16, 2017

Choose a reason for hiding this comment

joelvh Nov 16, 2017

Choose a reason for hiding this comment

pencil Nov 16, 2017

Choose a reason for hiding this comment

pencil Nov 16, 2017

Choose a reason for hiding this comment

joelvh Nov 16, 2017

Choose a reason for hiding this comment

dixalex commented Dec 21, 2018

abutterf commented Mar 8, 2021

joelvh commented Mar 9, 2021

pencil commented Mar 9, 2021

abutterf commented Mar 9, 2021

coveralls commented Nov 16, 2017 •

edited

Loading

coveralls commented Nov 16, 2017 •

edited

Loading

coveralls commented Nov 16, 2017 •

edited

Loading