Update Checkout Android SDK to v1.2.0, add compatibilty changes for RN 0.39 #9
Conversation
| "homepage": "https://github.com/razorpay/react-native-razorpay#readme", | ||
| "dependencies": { | ||
| "react-native": "^0.39.1" | ||
| } |
There was a problem hiding this comment.
Can we keep this as optional? My guess is that since this a breaking change (kind of), not many people will upgrade to this version of react-native. We should not be forcing this.
| } | ||
| }); | ||
|
|
||
| AppRegistry.registerComponent('example', () => example); |
There was a problem hiding this comment.
How and why is this different than the standard index.js?
There was a problem hiding this comment.
Each platform requires its own entry file. We can point both entrypoint files (index.android.js and index.ios.js) to the common code in index.js to avoid code duplication
There was a problem hiding this comment.
We should have been doing this already. Please make the necessary changes.
| @@ -16,6 +16,9 @@ | |||
| import com.facebook.react.bridge.Arguments; | |||
| import com.facebook.react.modules.core.DeviceEventManagerModule; | |||
| import com.razorpay.CheckoutActivity; | |||
| import com.razorpay.PaymentData; | |||
There was a problem hiding this comment.
Have we decided explicitly that we are exposing this? Because then, it needs to be consistent across all public repos (cordova, sample app, etc.)
There was a problem hiding this comment.
We've already exposed this for the auto-capture flow, no harm in exposing it here
| @@ -66,4 +66,4 @@ const styles = StyleSheet.create({ | |||
| } | |||
| }); | |||
|
|
|||
| AppRegistry.registerComponent('example', () => example); | |||
| AppRegistry.registerComponent('example', () => example); | |||
There was a problem hiding this comment.
Can you confirm that this does not break on iOS?
mb-14
force-pushed
the
f/android_update
branch
from
bbe9555 to
d1453d9
Compare
This should also fix #8