Promise based API #3
Conversation
| ``` | ||
| 4. Call RazorpayCheckout's `open` method with `options`, preferably on a user action: | ||
| 2. Call RazorpayCheckout's `open` method with `options` (preferably on a user | ||
| action) as a **JS Promise**. The `then` part corresponds to a successful payment, |
There was a problem hiding this comment.
openmethod withoptionsas a JS Promise
sounds a bit weird. How about the below ?
Call
RazorpayCheckout.openmethod with theoptions. The method returns a promise wherethenpart corresponds to a successful payment and thecatchpart corresponds to payment failure
There was a problem hiding this comment.
Yes, sounds great. Wasn't sure on terminology around Promises.
|
|
||
| static open(options, successCallback, errorCallback) { | ||
| return new Promise(function(resolve, reject) { | ||
| let removeSubscriptions = () => { |
There was a problem hiding this comment.
move the function outside open method
| static open(options, successCallback, errorCallback) { | ||
| return new Promise(function(resolve, reject) { | ||
| let removeSubscriptions = () => { | ||
| razorpayEvents.removeAllListeners('Razorpay::onPaymentSuccess'); |
There was a problem hiding this comment.
onPaymentSuccess, onPaymentError looks like a handler name.
How about Razorpay::PAYMENT_SUCCESS, Razorpay::PAYMENT_ERROR event names ?
|
|
||
| } | ||
|
|
||
| export {RazorpayCheckout}; |
There was a problem hiding this comment.
make it as default export like
export default RazorpayCheckout
| const { RazorpayCheckout, RazorpayEventEmitter } = Razorpay; | ||
|
|
||
| const razorpayEvents = new NativeEventEmitter(RazorpayEventEmitter); | ||
| import { RazorpayCheckout } from 'react-native-razorpay'; |
There was a problem hiding this comment.
with default export, this will be
import RazorpayCheckout from 'react-native-razorpay'
| { alert("Success: " + data.payment_id) } | ||
| ).catch(data => | ||
| { alert("Error: " + data.code + " | " + data.description) } | ||
| ); |
There was a problem hiding this comment.
change it to below style
RazorpayCheckout.open(options).then((data) => {
// handle success
alert(`Success: ${data.payment_id}`)
}).catch((error) => {
// handle error
alert(`Error: ${error.code} | ${error.description}`)
})
akshaybhalotia
force-pushed
the
f/promise_based_api
branch
from
82d9cfa to
996b316
Compare
akshaybhalotia
force-pushed
the
f/promise_based_api
branch
from
996b316 to
91ea1b7
Compare
|
lgtm 👍 |
Changes as per discussion on #2 .
Supports promise as well as callbacks (for example, as in razorpay/razorpay-cordova )