Skip to content

Commit

Permalink
Merge pull request #201 from mikehardy/allow-version-overrides
Browse files Browse the repository at this point in the history
fix: use react-native convention for version overrides, allows AndroidX to work
  • Loading branch information
sumedht authored Jun 19, 2019
2 parents afa9fc2 + 70b46fa commit ba399b1
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,17 @@ apply plugin: 'com.android.library'
repositories {
mavenCentral()
}
def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 26
buildToolsVersion "26.0.3"
compileSdkVersion safeExtGet('compileSdkVersion', 28)


defaultConfig {
minSdkVersion 16
targetSdkVersion 26
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 28)
versionCode 1
versionName "1.0"
}
Expand Down

0 comments on commit ba399b1

Please sign in to comment.