Skip to content

Commit

Permalink
Merge pull request #262 from razorpay/issue_template_changes
Browse files Browse the repository at this point in the history
Issue template changes added + Sample app updates.
  • Loading branch information
Nautiyalsachin authored May 24, 2020
2 parents d04fe36 + dc4ee8f commit 0991a22
Show file tree
Hide file tree
Showing 9 changed files with 170 additions and 13 deletions.
59 changes: 59 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
---
name: "🐛 Bug Report"
about: Report a reproducible bug or regression in React Native Razorpay Plugin.
title: ''
labels: 'Needs: Triage :mag:'

---

<!--
------ 👆 Click "Preview"!
HI! PLEASE STOP TO READ THIS!! IF YOU DO NOT FOLLOW THE INSTRUCTIONS, YOUR ISSUE
WILL LIKELY BE CLOSED.
* Please fill out this template with all the relevant information so we can understand what's going on and fix the issue. We appreciate bugs filed and PRs submitted!
-->

## Description

Please provide a clear and concise description of what the bug is. Include screenshots if needed.
Please test using the latest React Native Razorpay plugin release to make sure your issue has not already been fixed.

## Razorpay Package Version :
Open `Package.json`. > Copy `react-native-razorpay` version here.

## Xcode Version (iOS) :
Open Xcode > Go to `About Xcode` > copy the Xcode version here.


## Java and Gradle Version (android) :
Specify your Java and Gradle version.

### What you did:

<!-- What you were doing -->

### What happened:

<!-- Please provide the full error message/screenshots/anything -->

## Steps To Reproduce
Provide a detailed list of steps that reproduce the issue.

1.
2.

### Suggested solution:

<!--
It's ok if you don't have a suggested solution, but it really helps if you could
do a little digging to come up with some suggestions on how to improve things.
-->

## Code example, screenshot, or link to a repository:
Please provide a link to a repository on GitHub, or provide a minimal code example that reproduces the problem.
You may provide a screenshot of the application if you think it is relevant to your bug report.
Here are some tips for providing a minimal example: https://stackoverflow.com/help/mcve

5 changes: 5 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
blank_issues_enabled: false
contact_links:
- name: 🤔 Need some help in Integrations
url: https://razorpay.com/integrations/
about: Looking for help with your app? Please refer to the integration documentation.
43 changes: 43 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_Request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---
name: 💡 Feature Request
about: I have a suggestion (and might want to implement myself 🙂)!
---

<!--
Vote on feature requests by adding a 👍. This helps maintainers prioritize what
to work on.
* Please fill out this template with all the relevant information so we can
understand what's going on and fix the issue. We appreciate bugs filed and PRs
submitted!
* Please make sure that you are familiar with and follow the Code of Conduct for
this project (found in the CODE_OF_CONDUCT.md file).
-->

### Describe the feature you'd like:

<!--
A clear and concise description of what you want to happen. Add any considered
drawbacks.
-->

### Suggested implementation:

<!-- Helpful but optional 😀 -->

### Describe alternatives you've considered:

<!--
A clear and concise description of any alternative solutions or features you've
considered.
-->

### Teachability, Documentation, Adoption, Migration Strategy:

<!--
If you can, explain how users will be able to use this and possibly write out a
version of the docs.
-->
23 changes: 16 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@
React Native wrapper around our Android and iOS mobile SDKs

* [Installation](#installation)
* [Requirements](#requirements)
* [Linking](#linking)
* [Usage](#usage)
* [API](#api)
* [Troubleshooting](#troubleshooting)
* [Release Notes](#release-notes)
* [react-native-dom / react-native-web](#react-native-dom)
* [Example App](https://github.com/razorpay/react-native-razorpay/tree/master/example/SampleProject)
* [Proguard Rules](#proguard-rules)
* [Notes](#things-to-be-taken-care)
* [FAQ's](#faqs)
* [Contributing](#contributing)
* [License](#license)

The following documentation is only focussed on the react-native wrapper around our Android and iOS sdks. To know more about our react-native SDK, refer to the following documentation -

Expand All @@ -33,6 +36,12 @@ or using yarn:
```shell
yarn add react-native-razorpay
```
## Requirements

- iOS 10.0+ / macOS 10.12+ / tvOS 10.0+ / watchOS 3.0+
- Xcode 11+
- Swift 5.1+

## Linking

### Automatic
Expand Down Expand Up @@ -167,7 +176,7 @@ and the `catch` part corresponds to payment failure.
A descriptive [list of valid options for checkout][options] is available (under
Manual Checkout column).
## Proguard rules
## Proguard Rules
If you are using proguard for your builds, you need to add following lines to proguard files
```
-keepattributes *Annotation*
Expand All @@ -179,11 +188,11 @@ If you are using proguard for your builds, you need to add following lines to pr
}
```
## Things to be taken care:
## Things to be taken care
- The react native plugin is wrapper around native SDK, so it doesn't work with the tools like expo which doesn't support native modules.
## FAQ's:
## FAQ's
- Still having trouble with integrating our payment gateway? Follow [this link](https://github.com/razorpay/react-native-razorpay/wiki/FAQ's) for more info.
Expand Down
2 changes: 1 addition & 1 deletion example/SampleProject/ios/Podfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
platform :ios, '9.0'
platform :ios, '10.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

target 'SampleProject' do
Expand Down
12 changes: 11 additions & 1 deletion example/SampleProject/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ PODS:
- DoubleConversion
- glog
- glog (0.3.5)
- razorpay-pod (1.1.5)
- RCTRequired (0.61.5)
- RCTTypeSafety (0.61.5):
- FBLazyVector (= 0.61.5)
Expand Down Expand Up @@ -182,6 +183,9 @@ PODS:
- React-cxxreact (= 0.61.5)
- React-jsi (= 0.61.5)
- React-jsinspector (0.61.5)
- react-native-razorpay (2.1.33):
- razorpay-pod
- React
- React-RCTActionSheet (0.61.5):
- React-Core/RCTActionSheetHeaders (= 0.61.5)
- React-RCTAnimation (0.61.5):
Expand Down Expand Up @@ -236,6 +240,7 @@ DEPENDENCIES:
- React-jsi (from `../node_modules/react-native/ReactCommon/jsi`)
- React-jsiexecutor (from `../node_modules/react-native/ReactCommon/jsiexecutor`)
- React-jsinspector (from `../node_modules/react-native/ReactCommon/jsinspector`)
- react-native-razorpay (from `../node_modules/react-native-razorpay`)
- React-RCTActionSheet (from `../node_modules/react-native/Libraries/ActionSheetIOS`)
- React-RCTAnimation (from `../node_modules/react-native/Libraries/NativeAnimation`)
- React-RCTBlob (from `../node_modules/react-native/Libraries/Blob`)
Expand All @@ -252,6 +257,7 @@ DEPENDENCIES:
SPEC REPOS:
trunk:
- boost-for-react-native
- razorpay-pod

EXTERNAL SOURCES:
DoubleConversion:
Expand Down Expand Up @@ -282,6 +288,8 @@ EXTERNAL SOURCES:
:path: "../node_modules/react-native/ReactCommon/jsiexecutor"
React-jsinspector:
:path: "../node_modules/react-native/ReactCommon/jsinspector"
react-native-razorpay:
:path: "../node_modules/react-native-razorpay"
React-RCTActionSheet:
:path: "../node_modules/react-native/Libraries/ActionSheetIOS"
React-RCTAnimation:
Expand Down Expand Up @@ -312,6 +320,7 @@ SPEC CHECKSUMS:
FBReactNativeSpec: 118d0d177724c2d67f08a59136eb29ef5943ec75
Folly: 30e7936e1c45c08d884aa59369ed951a8e68cf51
glog: 1f3da668190260b06b429bb211bfbee5cd790c28
razorpay-pod: 31dd24ddb70275d82be12527b45001f9bc9f1be2
RCTRequired: b153add4da6e7dbc44aebf93f3cf4fcae392ddf1
RCTTypeSafety: 9aa1b91d7f9310fc6eadc3cf95126ffe818af320
React: b6a59ef847b2b40bb6e0180a97d0ca716969ac78
Expand All @@ -321,6 +330,7 @@ SPEC CHECKSUMS:
React-jsi: cb2cd74d7ccf4cffb071a46833613edc79cdf8f7
React-jsiexecutor: d5525f9ed5f782fdbacb64b9b01a43a9323d2386
React-jsinspector: fa0ecc501688c3c4c34f28834a76302233e29dc0
react-native-razorpay: 7be7bef396656a267014656cc227283e1788a94c
React-RCTActionSheet: 600b4d10e3aea0913b5a92256d2719c0cdd26d76
React-RCTAnimation: 791a87558389c80908ed06cc5dfc5e7920dfa360
React-RCTBlob: d89293cc0236d9cb0933d85e430b0bbe81ad1d72
Expand All @@ -333,6 +343,6 @@ SPEC CHECKSUMS:
ReactCommon: 198c7c8d3591f975e5431bec1b0b3b581aa1c5dd
Yoga: f2a7cd4280bfe2cca5a7aed98ba0eb3d1310f18b

PODFILE CHECKSUM: fed8dd1ec5f6935a2fa5e16f00ef4578ae9a319b
PODFILE CHECKSUM: db936ec42e64b4f4c8cee300226478ad9512d17c

COCOAPODS: 1.8.4
28 changes: 25 additions & 3 deletions example/SampleProject/ios/SampleProject.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,6 @@
6862FED1C4EAFF65154776CD /* Pods-SampleProjectTests.debug.xcconfig */,
E0C033B82B4C69AB3EBD4238 /* Pods-SampleProjectTests.release.xcconfig */,
);
name = Pods;
path = Pods;
sourceTree = "<group>";
};
Expand Down Expand Up @@ -230,6 +229,7 @@
13B07F8C1A680F5B00A75B9A /* Frameworks */,
13B07F8E1A680F5B00A75B9A /* Resources */,
00DD1BFF1BD5951E006B06BC /* Bundle React Native code and images */,
FC676FFFBF56D0CC12A12B47 /* [CP] Embed Pods Frameworks */,
);
buildRules = (
);
Expand Down Expand Up @@ -294,6 +294,7 @@
};
2D02E47A1E0B4A5D006451C7 = {
CreatedOnToolsVersion = 8.2.1;
DevelopmentTeam = 7GLVV3AVDP;
ProvisioningStyle = Automatic;
};
2D02E48F1E0B4A5D006451C7 = {
Expand All @@ -308,6 +309,7 @@
developmentRegion = English;
hasScannedForEncodings = 0;
knownRegions = (
English,
en,
Base,
);
Expand Down Expand Up @@ -475,6 +477,24 @@
shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n # print error to STDERR\n echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
showEnvVarsInLog = 0;
};
FC676FFFBF56D0CC12A12B47 /* [CP] Embed Pods Frameworks */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
"${PODS_ROOT}/Target Support Files/Pods-SampleProject/Pods-SampleProject-frameworks.sh",
"${PODS_ROOT}/razorpay-pod/Pod/Razorpay.framework",
);
name = "[CP] Embed Pods Frameworks";
outputPaths = (
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Razorpay.framework",
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "\"${PODS_ROOT}/Target Support Files/Pods-SampleProject/Pods-SampleProject-frameworks.sh\"\n";
showEnvVarsInLog = 0;
};
FD10A7F022414F080027D42C /* Start Packager */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
Expand Down Expand Up @@ -671,6 +691,7 @@
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 7GLVV3AVDP;
ENABLE_TESTABILITY = YES;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "SampleProject-tvOS/Info.plist";
Expand All @@ -680,7 +701,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.SampleProject-tvOS";
PRODUCT_BUNDLE_IDENTIFIER = com.test.REACT.SampleProjec;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = appletvos;
TARGETED_DEVICE_FAMILY = 3;
Expand All @@ -700,6 +721,7 @@
CLANG_WARN_SUSPICIOUS_MOVE = YES;
COPY_PHASE_STRIP = NO;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
DEVELOPMENT_TEAM = 3J5MJT3GNL;
GCC_NO_COMMON_BLOCKS = YES;
INFOPLIST_FILE = "SampleProject-tvOS/Info.plist";
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
Expand All @@ -708,7 +730,7 @@
"-ObjC",
"-lc++",
);
PRODUCT_BUNDLE_IDENTIFIER = "com.facebook.REACT.SampleProject-tvOS";
PRODUCT_BUNDLE_IDENTIFIER = com.facebook.REACT.SampleProjec;
PRODUCT_NAME = "$(TARGET_NAME)";
SDKROOT = appletvos;
TARGETED_DEVICE_FAMILY = 3;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>IDEDidComputeMac32BitWarning</key>
<true/>
</dict>
</plist>
3 changes: 2 additions & 1 deletion example/SampleProject/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
},
"dependencies": {
"react": "16.9.0",
"react-native": "0.61.5"
"react-native": "0.61.5",
"react-native-razorpay": "^2.1.33"
},
"devDependencies": {
"@babel/core": "^7.8.3",
Expand Down

0 comments on commit 0991a22

Please sign in to comment.