Fixing notes typecast issue #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Entity.php
Outdated
| if (in_array($data['entity'], $entities)) | ||
| $entity = $data; | ||
| } | ||
| else |
src/Entity.php
Outdated
| { | ||
| $entities = static::getDefinedEntitiesArray(); | ||
|
|
||
| if (isset($data['entity'])) | ||
| if (self::isNotes($key) === true) |
There was a problem hiding this comment.
make a generic isArrayableAttribute function.
Shift 'notes' to an array in the class.
src/Entity.php
Outdated
| @@ -138,7 +155,7 @@ public function fill($data) | |||
| { | |||
| if (is_array($v)) | |||
| { | |||
| $entity = static::buildEntity($v); | |||
| $entity = static::buildEntity($key, $v); | |||
There was a problem hiding this comment.
create a separate function for filling a single key => value pair.
There was a problem hiding this comment.
Refactored. Added a helper for the associate array case as well.
mayankamencherla
commented
Mar 8, 2017
src/Entity.php
Outdated
| { | ||
| $entities = static::getDefinedEntitiesArray(); | ||
|
|
||
| if (isset($data['entity'])) | ||
| if (self::isNotes($key) === true) |
src/Entity.php
Outdated
| if (in_array($data['entity'], $entities)) | ||
| $entity = $data; | ||
| } | ||
| else |
src/Entity.php
Outdated
| @@ -138,7 +155,7 @@ public function fill($data) | |||
| { | |||
| if (is_array($v)) | |||
| { | |||
| $entity = static::buildEntity($v); | |||
| $entity = static::buildEntity($key, $v); | |||
There was a problem hiding this comment.
Refactored. Added a helper for the associate array case as well.
|
@shashankkumar @73SL4 Kindly review. |
ccrims0n
reviewed
May 2, 2017
| @@ -67,15 +67,21 @@ protected function request($method, $relativeUrl, $data = null) | |||
| } | |||
| else | |||
| { | |||
| return static::buildEntity($response); | |||
| return static::buildEntity(null, $response); | |||
There was a problem hiding this comment.
@captn3m0 not sure if it's a good idea to pass null. Was thinking if we can make key as the second argument. What do you think?
|
Will reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[notes typecase] Hardcoding notes to be an array