-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stale): Stale implementation for issues and pr #334
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any most options that we can explore?
.github/workflows/stale.yml
Outdated
|
||
on: | ||
schedule: | ||
- cron: '29 1 * * *' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Let's add comments on what this cron time mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sidag95 added
.github/workflows/stale.yml
Outdated
stale-issue-label: 'Stale' | ||
stale-pr-label: 'Stale' | ||
days-before-stale: 30 | ||
days-before-close: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change this to 7. I think we should give folks a week before closing the issues.
Can you add some description for what is stale bot and where is it's documentation |
|
in stale.yml file ? |
In the PR description. |
i have updated the description is it looks good for you ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
on: | ||
schedule: | ||
- cron: '29 1 * * *' # Runs at 01:29 UTC every day. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question(non-blocking): Why such a specific time of the day? 😆
Stale
Whenever an issue or Pull Request has not been updated for a while, a stale label will be placed to mark it as stale. A closing comment may also be posted to notify contributors.
The stale label is removed if the Issue or Pull Request is updated, or if anyone comments on it.
Use the official Stale action located at https://github.com/actions/stale