-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Delete TPV Bank Account #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/Entity.php
Outdated
@@ -160,8 +160,10 @@ protected function getEntity() | |||
|
|||
public function fill($data) | |||
{ | |||
$attributes = array(); | |||
|
|||
$attributes = array(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ankitdas13 what is been changed here
src/VirtualAccount.php
Outdated
|
||
public function deleteAllowedPayer($id) | ||
{ | ||
$relativeUrl = $this->getEntityUrl() . $this->id . '/allowed_payers/'.$id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whats the difference between $this->id and $id
|
||
|
||
if(is_array($data)) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format this code properly
3cdc619
to
7cb8247
Compare
implement addAllowedPayer , deleteAllowedPayer function and update README