Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static late binding #20

Closed
wants to merge 3 commits into from
Closed

Fix static late binding #20

wants to merge 3 commits into from

Conversation

ccrims0n
Copy link
Contributor

captn3m0
captn3m0 reviewed Oct 11, 2016
View reviewed changes
tests/RazorpayTest.php

$payment = $data['items'][0];

$this->assertTrue(get_class($payment['notes']) === Entity::class);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we instead use StdClass for notes? Feels more logical rather than entity.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. I was actually thinking of creating a notes class.
Having a notes class makes much more sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer Notes class / StdClass over Entity. Let us do that?

@ccrims0n ccrims0n changed the title Fix static late binding [DONT MERGE] Fix static late binding Oct 13, 2016
@ccrims0n ccrims0n changed the title [DONT MERGE] Fix static late binding Fix static late binding Oct 13, 2016
@captn3m0 captn3m0 closed this Mar 1, 2017
@pronet79 pronet79 mentioned this pull request Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captn3m0 captn3m0 captn3m0 left review comments

Assignees

@captn3m0 captn3m0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccrims0n @captn3m0