Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-sdk Payment #232

Merged
merged 13 commits into from
Nov 10, 2021
Merged

Node-sdk Payment #232

merged 13 commits into from
Nov 10, 2021

Conversation

ankitdas13
Copy link
Contributor

added paymentVerification, otpSubmit, fetchPaymentDowntimeById, fetchPaymentDowntime, fetchCardDetails, transfer, fetchTransfer, fetchRefund, fetchMultipleRefund, createPaymentJson ,createRecurringPayment & edit function

command for unitTest : npm test

Copy link

@HancilSequeira HancilSequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HancilSequeira
Copy link

HancilSequeira commented Nov 2, 2021

PL signature verification is missing @ankitdas13

@HancilSequeira HancilSequeira self-requested a review November 2, 2021 13:50
}, callback);
},

paymentVerification: function paymentVerification() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move signature verification to a separate file like in php

dist/utils/razorpay-utils.js Show resolved Hide resolved
Copy link

@HancilSequeira HancilSequeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ace03uec ace03uec merged commit bc09f7d into master Nov 10, 2021
@ace03uec ace03uec deleted the payment_sdk branch November 10, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants