-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add partner's api's #286
Conversation
return processResponse(response); | ||
} | ||
|
||
public <T extends Entity> T post(String path, JSONObject requestObject) throws RazorpayException { | ||
Response response = ApiUtils.postRequest(path, requestObject, auth); | ||
public <T> T post(String version, String path, JSONObject requestObject) throws RazorpayException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made these changes because this api is returning an empty array []
also checking these method checking the return type . so after these changes now it supports empty []
return "settlement"; | ||
}else if(jsonObj.get("entity").toString().equals("payment.downtime")){ | ||
return "payment"; | ||
}else if(getClass(jsonObj.get("entity").toString()) == null){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this change because it was not able to check those entity properties which has settlement.ondemand
or payment.downtime
response example
throws RazorpayException { | ||
|
||
HttpUrl.Builder builder = getBuilder(path); | ||
HttpUrl.Builder builder = getBuilder(version, path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SDK now supports the v2 APIs , also for v3 if it will come up
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
============================================
+ Coverage 65.02% 73.67% +8.64%
- Complexity 192 240 +48
============================================
Files 46 53 +7
Lines 509 528 +19
Branches 19 20 +1
============================================
+ Hits 331 389 +58
+ Misses 160 120 -40
- Partials 18 19 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM test one more time before merging. Minor comments discussed over the call.
Links for api reference you can also check this doc for more details
Account : https://razorpay.com/docs/api/partners/account-onboarding
Stakeholder : https://razorpay.com/docs/api/partners/stakeholder
Product configuration : https://razorpay.com/docs/api/partners/product-configuration
Webhook : https://razorpay.com/docs/api/partners/webhooks/#create-a-webhook
Terms & condition : https://razorpay.com/docs/api/partners/terms-conditions
Linked accont : https://razorpay.com/docs/partners/route/linked-accounts
Token Sharing : https://razorpay.com/docs/partners/aggregators/partner-auth/token-sharing
Iin validation : https://razorpay.com/docs/payments/payment-methods/cards/token-hq/merchant-requestor-with-network-tokens/iin-validation
Card fingerprints : https://razorpay.com/docs/api/payments/cards/fingerprints#using-card-number