Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix/preferences #66

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Bug fix/preferences #66

wants to merge 7 commits into from

Conversation

ramprasadAnand
Copy link
Contributor

Details

  • Get payment methods bug fix
  • Added additional param in the get payment methods function
  • Updated the example project to latest version
Details Description
Asana/Jira link https://razorpay.atlassian.net/browse/CEPF-1210
Slack thread https://razorpay.slack.com/archives/C05BLPDMAPQ/p1698757262302649
Design source N/A
Tech Specs https://docs.google.com/document/d/1uip059Cttk9gwht2iUI8Sop36N7qkFdRISQAN1LZlAc/edit?usp=sharing
Product Specs N/A
Related PRs N/A
Breaking change (with back-support) Yes
Documentation update needed Yes
QA sign-off by N/A
Deployment Checklist JiraId N/A
Test Case Document URL Please paste test case document link here....

Note :- Please follow the below points while attaching test cases document link below:

  • This is to identify if BVT needs to be added for the new changes. So, either of the two labels can be added: Testing or TestingNotRequired.
  • If label Tested is added then test cases document URL is mandatory.
  • Link added should be a valid URL and accessible throughout the org.
  • If the branch name contains hotfix / revert by default the BVT workflow check for adding new test will pass.

Changelog

  • Bug fix on the getPaymentMethods function added new parameter to pass payload.

Checklist

  • **Dev Testing Done
  • **Sanity Testing Done
  • Manual testing or integration testing done.
  • **QA Sign-Off given
  • Updated/Added Unit Tests.
  • Analytics event added if new feature
  • **Ensure all functions / code-blocks are wrapped in try/catch at some level (Non critical errors should not bubble up to cause payment blockers)
  • **Ensure all errors are captured using error-service with severity levels
  • Added explanatory comment for tricky code explaining "why".
  • **Tested on major devices / simulators.
  • Detailed description about this PR added ?

JIRA TICKETS Associated to this PR

Details JIRA Link
CEPF-1209 https://razorpay.atlassian.net/browse/CEPF-1209
CEPF-1210 https://razorpay.atlassian.net/browse/CEPF-1210

@ramprasadAnand
Local Changes
7bef93c
@ramprasadAnand
Merge branch 'master' of github.com:razorpay/razorpay-flutter-customu…
68b4980 
…i into bugFix/preferences
@ramprasadAnand
Bug fix
8c73bc6 
- Get payment methods bug fix
- Added additional param in the get payment methods function
- Updated the example project to latest version
@ramprasadAnand ramprasadAnand added DevTestingStarted DevTestingStarted TestingNotRequired TestingNotRequired label for BVT and removed DevTestingStarted DevTestingStarted labels Nov 2, 2023
ramprasadAnand and others added 3 commits November 2, 2023 15:35
@ramprasadAnand
- Review comments addressed
4e87398 
- Wrapped string error response in a json object.
@ramprasadAnand
- Handled the optional payload as optional parameter
b2850f6
@vivekshindhe
feat: getPaymentMethods with subscriptionId implementation for androi…
82ca6ca 
…d;bug-fix: added key code for getPaymentMethods failure in iOS.
@ramprasadAnand ramprasadAnand added DevTestingStarted DevTestingStarted TestingNotRequired TestingNotRequired label for BVT and removed TestingNotRequired TestingNotRequired label for BVT labels Nov 6, 2023
@vivekshindhe vivekshindhe removed the DevTestingStarted DevTestingStarted label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekshindhe vivekshindhe vivekshindhe approved these changes

Assignees
No one assigned
Labels
TestingNotRequired TestingNotRequired label for BVT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramprasadAnand @vivekshindhe