added net4.8 support #131
Merged
added net4.8 support #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwatang
reviewed
Jun 18, 2024
shwatang
reviewed
Jun 18, 2024
net48/Properties/AssemblyInfo.cs
Outdated
Comment on lines
8
to
13
| [assembly: AssemblyTitle("RazorpayClient48")] | ||
| [assembly: AssemblyDescription("")] | ||
| [assembly: AssemblyConfiguration("")] | ||
| [assembly: AssemblyCompany("")] | ||
| [assembly: AssemblyProduct("RazorpayClient48")] | ||
| [assembly: AssemblyCopyright("Copyright © 2024")] |
There was a problem hiding this comment.
Suggested change
| [assembly: AssemblyTitle("RazorpayClient48")] | |
| [assembly: AssemblyDescription("")] | |
| [assembly: AssemblyConfiguration("")] | |
| [assembly: AssemblyCompany("")] | |
| [assembly: AssemblyProduct("RazorpayClient48")] | |
| [assembly: AssemblyCopyright("Copyright © 2024")] | |
| [assembly: AssemblyTitle("Razorpay")] | |
| [assembly: AssemblyDescription("Razorpay SDK for .Net")] | |
| [assembly: AssemblyConfiguration("")] | |
| [assembly: AssemblyCompany("Razorpay Software Private Limited")] | |
| [assembly: AssemblyProduct("Razorpay.API")] | |
| [assembly: AssemblyCopyright("Copyright © 2015 - 2024")] |
Should't it be this? Correct me if mistaken.
There was a problem hiding this comment.
updated
shwatang
reviewed
Jun 18, 2024
net48/packages.config
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Newtonsoft.Json" version="13.0.3" targetFramework="net48" /> | ||
| <package id="Portable.BouncyCastle" version="1.8.0" targetFramework="net48" /> |
There was a problem hiding this comment.
why changed it from 1.9.0 version?
There was a problem hiding this comment.
updated
shwatang
reviewed
Jun 18, 2024
net48/RazorpayClient48.csproj
Outdated
| @@ -0,0 +1,199 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
There was a problem hiding this comment.
why we not adding DefaultTargets key?
There was a problem hiding this comment.
added
shwatang
reviewed
Jun 18, 2024
net48/RazorpayClient48.csproj
Outdated
| <AssemblyName>Razorpay</AssemblyName> | ||
| <TargetFrameworkVersion>v4.8</TargetFrameworkVersion> | ||
| <FileAlignment>512</FileAlignment> | ||
| <Deterministic>true</Deterministic> |
shwatang
reviewed
Jun 18, 2024
net48/RazorpayClient48.csproj
Outdated
| <StartupObject /> | ||
| </PropertyGroup> | ||
| <ItemGroup> | ||
| <Reference Include="crypto, Version=1.8.0.0, Culture=neutral, PublicKeyToken=0e99375e54769942, processorArchitecture=MSIL"> |
There was a problem hiding this comment.
Is Include="crypto the correct way? Shouldnt it be BouncyCastle.Crypto ?
There was a problem hiding this comment.
updated
shwatang
reviewed
Jun 18, 2024
net48/RazorpayClient48.csproj
Outdated
Comment on lines
38
to
41
| <HintPath>packages\Portable.BouncyCastle.1.8.0\lib\net46\crypto.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="Newtonsoft.Json, Version=13.0.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed, processorArchitecture=MSIL"> | ||
| <HintPath>packages\Newtonsoft.Json.13.0.3\lib\net45\Newtonsoft.Json.dll</HintPath> |
There was a problem hiding this comment.
Please once check the HintPath and confirm if its correct.
shwatang
reviewed
Jun 18, 2024
Comment on lines
+44
to
+52
| <Reference Include="System.IO.FileSystem, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> | ||
| <HintPath>packages\System.IO.FileSystem.4.0.0\lib\net46\System.IO.FileSystem.dll</HintPath> | ||
| <Private>True</Private> | ||
| <Private>True</Private> | ||
| </Reference> | ||
| <Reference Include="System.IO.FileSystem.Primitives, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL"> | ||
| <HintPath>packages\System.IO.FileSystem.Primitives.4.0.0\lib\net46\System.IO.FileSystem.Primitives.dll</HintPath> | ||
| <Private>True</Private> | ||
| <Private>True</Private> |
There was a problem hiding this comment.
Why including this as part this PR?
There was a problem hiding this comment.
to use System.Net.HttpWebRequest namespace in net4.8 we need to add reference.
shwatang
reviewed
Jun 18, 2024
I addressed these comments and made changes, as well as testing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for .net 4.8