RANGER-3387: fix for PMD violation - #2

razorpay · Jul 25, 2022 · e17ffa3 · e17ffa3
1 parent ee2dc9b
commit e17ffa3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java b/...admin/src/main/java/org/apache/ranger/security/web/filter/RangerCSRFPreventionFilter.java
@@ -187,8 +187,8 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
 		if (IS_CSRF_ENABLED) {
 			final HttpServletRequest httpRequest = (HttpServletRequest)request;
 		    final HttpServletResponse httpResponse = (HttpServletResponse)response;
-		    Boolean spnegoEnabled = httpRequest.getAttribute("spnegoEnabled") != null ? Boolean.valueOf(String.valueOf(httpRequest.getAttribute("spnegoEnabled"))) : false;
-		    Boolean trustedProxyEnabled = httpRequest.getAttribute("trustedProxyEnabled") != null ? Boolean.valueOf(String.valueOf(httpRequest.getAttribute("trustedProxyEnabled"))) : false;
+		    Boolean spnegoEnabled = httpRequest.getAttribute("spnegoEnabled") != null && Boolean.valueOf(String.valueOf(httpRequest.getAttribute("spnegoEnabled")));
+		    Boolean trustedProxyEnabled = httpRequest.getAttribute("trustedProxyEnabled") != null && Boolean.valueOf(String.valueOf(httpRequest.getAttribute("trustedProxyEnabled")));
 		    handleHttpInteraction(new ServletFilterHttpInteraction(httpRequest, httpResponse, chain), spnegoEnabled, trustedProxyEnabled);
 		}else{
 			chain.doFilter(request, response);