[trino] Fix logging in Trino plugin

Ranger plugin access control class is injected via classloader, its logger needs to go through trino's logger. More details: facebookarchive/swift#287 (comment) Signed-off-by: Utkarsh Saxena <[email protected]>
razorpay · Oct 18, 2023 · d344a4d · d344a4d
1 parent da92e12
commit d344a4d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/plugin-trino/pom.xml b/plugin-trino/pom.xml
@@ -37,6 +37,11 @@
             <artifactId>trino-spi</artifactId>
             <version>${trino.version}</version>
         </dependency>
+        <dependency>
+            <groupId>io.airlift</groupId>
+            <artifactId>log</artifactId>
+            <version>${trino.airlift.version}</version>
+        </dependency>
         <dependency>
             <groupId>io.trino</groupId>
             <artifactId>trino-jdbc</artifactId>

diff --git a/...main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java b/...main/java/org/apache/ranger/authorization/trino/authorizer/RangerSystemAccessControl.java
@@ -41,8 +41,7 @@
 import org.apache.ranger.plugin.policyengine.RangerAccessResourceImpl;
 import org.apache.ranger.plugin.policyengine.RangerAccessResult;
 import org.apache.ranger.plugin.service.RangerBasePlugin;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import io.airlift.log.Logger;
 
 import java.io.IOException;
 import java.net.URL;
@@ -62,7 +61,7 @@
 
 public class RangerSystemAccessControl
   implements SystemAccessControl {
-  private static Logger LOG = LoggerFactory.getLogger(RangerSystemAccessControl.class);
+  private static final Logger LOG = Logger.get(RangerSystemAccessControl.class);
 
   final public static String RANGER_CONFIG_KEYTAB = "ranger.keytab";
   final public static String RANGER_CONFIG_PRINCIPAL = "ranger.principal";

diff --git a/pom.xml b/pom.xml
@@ -207,7 +207,7 @@
         <presto.re2j.version>1.1</presto.re2j.version>
 
         <!-- trino plugin deps -->
-        <trino.airlift.version>0.192</trino.airlift.version>
+        <trino.airlift.version>208</trino.airlift.version>
         <trino.bval-jsr.version>2.0.0</trino.bval-jsr.version>
         <trino.guice.version>4.2.2</trino.guice.version>
         <trino.guava.version>26.0-jre</trino.guava.version>