Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update review_ci.yml #470

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update review_ci.yml #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions .github/workflows/review_ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,14 @@ on:
jobs:
reviewdog:
name: Run reviewdog
runs-on: [ self-hosted ]
container:
image: c.rzp.io/proxy_dockerhub/golang:1.16.5-alpine3.13
credentials:
username: ${{ secrets.HARBOR_DOCKER_USERNAME }}
password: ${{ secrets.HARBOR_DOCKER_PASSWORD }}
volumes:
- /etc/hosts:/etc/hosts
runs-on: ubuntu-latest
container: golang:1.16.5-alpine3.13
Copy link

@vishu-25 vishu-25 Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to Go v1.22 or v1.23 if possible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can has to be taken by owner of apps. As devops we are not aware of its function testing.

steps:
- name: checkout
id: checkout
uses: actions/checkout@v2
uses: actions/checkout@v1
with:
submodules: true
- name: install prerequisites
run: |
apk add --update --no-cache --repository https://dl-4.alpinelinux.org/alpine/latest-stable/community/ build-base gcc make git librdkafka-dev pkgconf curl bash sudo
Expand All @@ -30,7 +26,7 @@ jobs:
go mod vendor
- name: Target repo permission update # Workaround for CVE-2022-24765
run: |
chown -R root:root $GITHUB_WORKSPACE
sudo chown -R root:root $GITHUB_WORKSPACE
- name: golangci-lint
uses: reviewdog/action-golangci-lint@v1
with:
Expand Down
Loading