Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check for primary topic #445

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akashgoyal96
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Is it a breaking change?

How do we intend to rollback or handle backward compatibility in case something breaks?
Can this change be tested effectively via canary?

Screenshots:

Include a screenshot of the changes, if applicable.

Checklist Exception

  • My change doesn't require the below checklist to be updated.
    Please add a description on why it is not applicable.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works (if applicable)
  • I have added integration tests for the new feature (if applicable)
  • I have manually tested my code to the best of my abilities.

@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #445 (b53c81e) into master (707fc42) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   66.40%   66.43%   +0.03%     
==========================================
  Files         127      127              
  Lines       10176    10177       +1     
==========================================
+ Hits         6757     6761       +4     
+ Misses       2996     2994       -2     
+ Partials      423      422       -1     
Flag Coverage Δ
integration 47.62% <ø> (ø)
unittests 63.55% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/tasks/publishertask.go 84.61% <100.00%> (+0.13%) ⬆️
internal/subscriber/retry/delayconsumer.go 72.28% <0.00%> (+1.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vnktram
Copy link
Contributor

vnktram commented Nov 8, 2022

Let's plan to release this on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants