formatNumber method from Currency Module is throwing error while running in a non-browser environment (e.g., Node.js)

[sakigo9]

Steps to reproduce the issue

1. Firstly I installed the @razorpay/i18nify package inside my Node app using npm i @razorpay/i18nify.
2. Using the latest version of the app i.e. "@razorpay/i18nify": "^1.2.1".

"dependencies": {
    "@razorpay/i18nify": "^1.2.1",
    "nodemon": "^3.0.2"
}

3. Then, I tried using the method called formatNumber from the Currency Module. Refer to the below code to replicate the issue

const { formatNumber } = require("@razorpay/i18nify");
console.log(formatNumber("1000.5", { currency: "USD" }));

4. Received following error

 

Expected vs. Actual behavior

1. To verify this method I used the same method in the browser environment and it worked well.
2. Refer to the following image which verified that this method worked well with a browser-based environment (used React.js)

 

Root Cause(Based on my observation)

The window.navigator object is specific to web browsers and is not available in Node.js. However, if we navigate here then we can observe that we are trying to use navigator which will work well for a browser environment. But Node.js is not running in a browser context, so you won't have access to browser-specific APIs like window.navigator.

 
I've reproduced the issue locally. I have a fix for this solution, once this issue is verified, please allow me to fix this issue through a PR.

Please let me know if any additional information is required.

[sakigo9]

Just a quick question. If someone raises an issue then can't they fix that issue as well?
For this issue, I raised an issue and asked if I could fix it or not. But didn't get the opportunity to contribute.

Did I miss something or someone outside Razorpay are not allowed to fix issues? Can someone guide me on this?

[RgnDunes]

@sakigo9 to answer your above question, if someone raises an issue then they CAN fix that issue as well. Thanks for raising the issue and a PR for it's fix. Have left some comments, please address those.

[sakigo9]

Thanks for answering @RgnDunes.
Sure will have a look at your comment on the PR.