Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-3588: Switching the markdown engine #37

Merged
merged 4 commits into from
Aug 20, 2020
Merged

WEB-3588: Switching the markdown engine #37

merged 4 commits into from
Aug 20, 2020

Conversation

sammyd
Copy link
Contributor

@sammyd sammyd commented Aug 20, 2020

I discovered that codex actually uses CommonMark as a standard, which explains why we're seeing discrepancies between the PDF and the site. This switches it—I think it should fix some issues, and hopefully not create any regressions.

@sammyd sammyd requested a review from roelbondoc August 20, 2020 16:48
Copy link
Contributor

@roelbondoc roelbondoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice how it's almost a drop in replacement!

@sammyd sammyd merged commit 76d937c into development Aug 20, 2020
@sammyd sammyd deleted the WEB-3588 branch August 20, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants