Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-6880: Adding module_type and program_shortcode to module + lesson #252

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

sammyd
Copy link
Contributor

@sammyd sammyd commented Mar 13, 2024

This introduces info and study modules. Study is the default, info has some different types.

This introduces info and study modules. Study is the default, info
has some different types.
@@ -134,7 +134,7 @@ def render_content_module(module_file:, local: false)
image_provider&.process
renderer = Renderer::ContentModule.new(content_module, image_provider:)
renderer.render
content_module
p content_module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this p intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thank you!

Copy link
Contributor

@KapilSachdev KapilSachdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good except for the print statement edith mentioned.

I assume program_shortcode is just for reference as the content eventually is linked manually by admin.

@sammyd
Copy link
Contributor Author

sammyd commented Mar 13, 2024

Seems good except for the print statement edith mentioned.

I assume program_shortcode is just for reference as the content eventually is linked manually by admin.

Yeah—just for reference. I'm intending on using it as a display thing for admins to more easily find these things in carolus. Or possibly even filtering by it.

@sammyd sammyd merged commit 7a86003 into development Mar 13, 2024
1 check passed
@sammyd sammyd deleted the WEB-6880 branch March 13, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants