WEB-6755: Gem updates #238
Conversation
.ruby-version
Outdated
| @@ -1 +1 @@ | |||
| 3.2.0 | |||
| 3.3.0 | |||
There was a problem hiding this comment.
Would be better to keep it at 3.2 to be consistent with Dockerfile
There was a problem hiding this comment.
Oh my mistake—I attempted to get to 3.3 and had to rollback. Forgot to do here—thanks!
.rubocop.yml
Outdated
| @@ -1,5 +1,5 @@ | |||
| AllCops: | |||
| TargetRubyVersion: 3.2 | |||
| TargetRubyVersion: 3.3 | |||
There was a problem hiding this comment.
Would be better to keep it at 3.2 to be consistent with Dockerfile
| @@ -55,20 +55,6 @@ def slides | |||
| snapshotter.generate | |||
| end | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I think this works?
I guess I had reviewed the module text/video content UI using it.
There was a problem hiding this comment.
I think it should work...
| ENV RUBY_ENV=${RUBY_ENV} | ||
|
|
||
| ARG RUNTIME_PACKAGES="imagemagick git tzdata" | ||
| ARG TEST_AND_DEV_PACKAGES="bash build-base libsodium-dev" |
There was a problem hiding this comment.
Maybe we don't need libsodium-dev here as we are already copying libsodium from builder below.
There was a problem hiding this comment.
I wasn't sure whether it might also need header files or something else that might be part of the package when building a new version of the gem? Since this was only for test and development I thought it could probably stay in.
Attempting to upgrade to ruby 3.3, but it doesn't work on aarch64 yet
Upgraded gems tho, and attempted to make a multi-stage build Dockerfile. Please check this cos I'm not 100% of what I'm doing.
Not 100% I've got it right, but if I have, it's a size reduction from 600MB to 200MB, on the one image where the size does actually matter :)