Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-6519: Fix slides #220

Merged
merged 3 commits into from
Oct 9, 2023
Merged

WEB-6519: Fix slides #220

merged 3 commits into from
Oct 9, 2023

Conversation

sammyd
Copy link
Contributor

@sammyd sammyd commented Oct 9, 2023

  • Design didn't have the correct elements
  • Server paths didn't include lessons, so not all slides were accessible
  • Generator needs to support different settings for videos vs modules
  • Default output location is different
  • Ref wasn't being parsed correctly

@sammyd sammyd requested a review from KapilSachdev October 9, 2023 20:31
Copy link
Contributor

@KapilSachdev KapilSachdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sammyd sammyd merged commit 86a0fc9 into development Oct 9, 2023
1 check passed
@sammyd sammyd deleted the WEB-6519 branch October 9, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants