-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Raccoon CLI #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10449927361Details
💛 - Coveralls |
This makes it easier to parse data from config files and cli flags
ravisuhag
reviewed
Aug 14, 2024
|
||
import ( | ||
"github.com/MakeNowJust/heredoc" | ||
"github.com/spf13/cobra" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turtleDev Let's use salt/cmdx for cli.
The docs incorrectly specified their values in seconds, when in reality raccoon expects them to be milliseconds
It's now called PUBLISHER_KAFKA_DELIVERY_CHANNEL_SIZE
raccoon now uses integer values to represent most duration parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
server
command to start the applicationthere are no flags for dynamic kafka client configs. This is a limitation of the way raccoon handles these configs internally. We recommend users use env variables or config file to pass these values to raccoon.default values are not shown in flags.default values for flags are available-c
flag to specify the path of the config file.WORKER_KAFKA_DELIVERY_CHANNEL_SIZE
is nowPUBLISHER_KAFKA_DELIVERY_CHANNEL_SIZE
since it's specific to kafka publisher.Preview: