Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics: Producer metric overhaul + grafana dashboard #90

Merged
merged 25 commits into from
Jul 31, 2024

Conversation

turtleDev
Copy link
Contributor

@turtleDev turtleDev commented Jul 29, 2024

This change:

  • removes false positives from producer delivery metrics ${PUBLISHER}_event_(un)delivered_total
  • adds metrics for hitting quota limits on pubsub and kinesis
  • adds a grafana dashboard with support for Prometheus data source.

@coveralls
Copy link

coveralls commented Jul 29, 2024

Pull Request Test Coverage Report for Build 10166318092

Details

  • 142 of 229 (62.01%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 46.275%

Changes Missing Coverage Covered Lines Changed/Added Lines %
publisher/pubsub/error.go 0 1 0.0%
worker/worker.go 0 1 0.0%
publisher/pubsub/pubsub.go 41 83 49.4%
publisher/kinesis/kinesis.go 42 85 49.41%
Files with Coverage Reduction New Missed Lines %
publisher/kinesis/kinesis.go 2 70.87%
Totals Coverage Status
Change from base Build 10036204782: 0.003%
Covered Lines: 1149
Relevant Lines: 2483

💛 - Coveralls

@ravisuhag ravisuhag merged commit d8a60ef into main Jul 31, 2024
8 checks passed
@ravisuhag ravisuhag deleted the metrics-dashboard branch July 31, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants