feat: add cors support #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
punit-kulal
commented
Aug 29, 2023
•
punit-kulal
commented
- Support for CORS in Rest backend.
- Support is added by setting appropriate response headers.
- Support for the following new env:
- SERVER_CORS_ENABLED
- SERVER_CORS_ALLOWED_ORIGIN
- SERVER_CORS_ALLOWED_METHODS
- SERVER_CORS_ALLOWED_HEADERS
- SERVER_CORS_ALLOW_CREDENTIALS
- SERVER_CORS_PREFLIGHT_MAX_AGE_SECONDS
- Added docs for the respective headers
- Integration tests to confirm Allow Origin Headers are passed only for whitelisted Origins
- Integration tests to check behaviour of preflight requests.
punit-kulal
force-pushed
the
cors-support
branch
from
11c925a
to
2f838aa
Compare
prakharmathur82
requested changes
Aug 31, 2023
|
Can we also add documentation for new configs and also mention how these configs will work in case of websocket |
prakharmathur82
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.