-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add readme and examples for js client #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
prakharmathur82
commented
Aug 25, 2023
- Add README
- Add example usages
prakharmathur82
force-pushed
the
docs-js-client
branch
5 times, most recently
from
August 25, 2023 12:04
85c479a
to
4754cad
Compare
prakharmathur82
force-pushed
the
docs-js-client
branch
from
August 25, 2023 12:06
4754cad
to
a9e6bab
Compare
punit-kulal
requested changes
Aug 28, 2023
punit-kulal
reviewed
Aug 28, 2023
punit-kulal
reviewed
Aug 28, 2023
You would also want to add a files field in your client's package.json or add a .npmignore and make sure the examples and test folders folders is excluded. Otherwise it will also be included in your build/dist. |
prakharmathur82
force-pushed
the
docs-js-client
branch
2 times, most recently
from
August 28, 2023 07:19
7114c63
to
71c739e
Compare
prakharmathur82
force-pushed
the
docs-js-client
branch
from
August 28, 2023 10:21
71c739e
to
d7ce2fd
Compare
punit-kulal
approved these changes
Aug 28, 2023
ravisuhag
added a commit
that referenced
this pull request
Sep 24, 2023
* feat: add js client to send JSON data to server (#60) * feat: add support for proto serde in js client (#62) * feat: add ci stages for js client (#68) * docs: add readme and examples for js client (#70) * chore:bump version --------- Co-authored-by: Ravi Suhag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.