Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rcore][GLFW] Fix warning on windows in MSVC #4447

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

JeffM2501
Copy link
Contributor

There is an error with the forward declaration of the winMM functions when building on MSVC. Inconsistent DLL linkage.
This is not a critical warning, so this PR disables it.
This PR also removes the timeBeginPeriod declaration as it is no longer needed.

@JeffM2501
Copy link
Contributor Author

AFAIK timeBeginPeriod may still be necessary, as its operation changed on Windows 10, version 2004 (see Remarks section, third paragraph, of the documentation), which was on May 2020, not that long ago. There's a lot of hardware still running older versions of Windows (e.g.: automation, industry, etc).

It's not called in that file, thus it does not need to be forward declared, it'll still be linked by the lib if some other internal file uses it, like GLFW itself.

@raysan5 raysan5 changed the title [Platform GLFW] Fix warning on windows in MSVC [rcore][GLFW] Fix warning on windows in MSVC Oct 27, 2024
@raysan5 raysan5 merged commit 743e557 into raysan5:master Oct 29, 2024
14 checks passed
@raysan5
Copy link
Owner

raysan5 commented Oct 29, 2024

@JeffM2501 thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants