[CORE] Support for SetWindowTitle and InitWindow for web #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed SetWindowTitle's description
SetWindowTitle now works on web
InitWindow title now works with web platform too.
|
@VitusVeit Nice improvement! Thank you very much! |
|
No problem! And thank you for writing such a helpful library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
SetWindowTitleandInitWindowwill now change the current tab name of the browser, if compiled for the web platform.They use the emscripten function
emscripten_set_window_title.Why:
As stated in the header file, the
SetWindowTitlefunction works only for desktop.But this feature can be useful also on the web, for example by setting the tab title to the one of your game/app to make it more recognizable without having to change the title manually in the HTML file or interacting directly with emscripten.
Status:
Tested on Windows 11 with the latest version of emscripten on chrome with raylib's basic window example with no errors nor code changes.