Simplify reduce and add min_by and max_by #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `sum` and `product` became their own things, `reduce` doesn't need the `ReduceOp` abstraction any more.
We can use a simpler match with `fold` in implementing `reduce_with`, before passing to the more complicated match where both sides are options. This may help the compiler optimize better.
These call a user's function to compare values, just like the methods added to `Iterator` in Rust 1.15.0.
| (Some(v), None) | (None, Some(v)) => Some(v), | ||
| (None, None) => None, | ||
| }) | ||
| self.fold(|| None, |opt_a, b| match opt_a { |
There was a problem hiding this comment.
It seems like a waste to wrap values in Some only to immediately match that away. It requires inlining and optimization to realize that the right side always has something while folding. In practice, I couldn't measure a difference, so I'll drop this change if you prefer.
There was a problem hiding this comment.
I see. That's true. I don't have a strong opinion, just curious. I agree that it seems like this formulation might unlock some optimization somehow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.