-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Revert "Pyarrow Segfault Regression Test (#7568) (#7805) #7811
Conversation
Can one of the admins verify this patch? |
Test PASSed. |
doc/requirements-doc.txt
Outdated
@@ -11,6 +11,7 @@ opencv-python-headless | |||
pandas | |||
pickle5 | |||
pillow | |||
pyarrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add pyarrow
in python/setup.py
and ci/travis/install-dependencies.sh
. And I think we shopuld enforece pyarrow version to ge greater than 0.15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This is definitely not the right location.
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test PASSed. |
Test FAILed. |
@ijrsvt Is this a critical PR? Do you think it should be merged before the next relesase? |
@chaokunyang can I ask what's the status on this PR? Is it working? can you fix merge some merge conflict? I'm happy to merge this PR given test passes. |
Stale & not causing problems for the time being |
Why are these changes needed?
Related issue number
#7805
Checks
scripts/format.sh
to lint the changes in this PR.