Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Pyarrow Segfault Regression Test (#7568) (#7805) #7811

Closed
wants to merge 16 commits into from

Conversation

ijrsvt
Copy link
Contributor

@ijrsvt ijrsvt commented Mar 30, 2020

Why are these changes needed?

Related issue number

#7805

Checks

@ijrsvt ijrsvt changed the title Revert revert Pyarrow SegfaultFix Revert "Revert "Pyarrow Segfault Regression Test (#7568) (#7805) Mar 30, 2020
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23917/
Test PASSed.

@@ -11,6 +11,7 @@ opencv-python-headless
pandas
pickle5
pillow
pyarrow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add pyarrow in python/setup.py and ci/travis/install-dependencies.sh. And I think we shopuld enforece pyarrow version to ge greater than 0.15

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is definitely not the right location.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23923/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23928/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23953/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/23970/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24000/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24002/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24004/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24082/
Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24089/
Test PASSed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/24186/
Test FAILed.

@rkooo567
Copy link
Contributor

@ijrsvt Is this a critical PR? Do you think it should be merged before the next relesase?

@simon-mo
Copy link
Contributor

simon-mo commented Jul 6, 2020

@chaokunyang can I ask what's the status on this PR? Is it working? can you fix merge some merge conflict? I'm happy to merge this PR given test passes.

@ijrsvt
Copy link
Contributor Author

ijrsvt commented Aug 11, 2020

Stale & not causing problems for the time being

@ijrsvt ijrsvt closed this Aug 11, 2020
@ijrsvt ijrsvt deleted the PYSegRedux branch August 26, 2020 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants