[metrics][prometheus] Support ray metrics shutdown-prometheus
#48799
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
kevin85421
requested review from
maxpumperla,
pcmoritz and
a team
as code owners
MengjinYan
approved these changes
Nov 20, 2024
| To stop Prometheus, run the following commands: | ||
|
|
||
| ```sh | ||
| # case 1: Ray > 2.40 |
There was a problem hiding this comment.
Just curious, how do we know which Ray version the change will be added?
There was a problem hiding this comment.
Currently, the CI team is preparing the release candidates for Ray 2.40, so I guess it will be included in Ray 2.41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Users need to run
kill <PID>to shut down Prometheus launched byray metrics launch-prometheus.This PR enables the Prometheus lifecycle API and implements
ray metrics shutdown-prometheus, which sends a POST request tohttp://localhost:9090/-/quitto gracefully shut down Prometheus.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.