Preserve ray/serve/generated when creating softlink for serve package #48793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mimi Liao <[email protected]>
python/ray/setup-dev.py
Outdated
| if package == "serve": | ||
| # Copy generated folder to a temp dir | ||
| generated_folder = os.path.join(package_home, "generated") | ||
| temp_dir = "/tmp/ray/" |
There was a problem hiding this comment.
Suggested change
| temp_dir = "/tmp/ray/" | |
| temp_dir = "/tmp/ray/_serve/" |
There was a problem hiding this comment.
To avoid collisions with other libs
python/ray/setup-dev.py
Outdated
| subprocess.check_call(sudo + ["rm", "-rf", package_home]) | ||
| subprocess.check_call(sudo + ["ln", "-s", local_home, package_home]) | ||
|
|
||
| # Move generated folder to local_home | ||
| if package == "serve": | ||
| tmp_generated_folder = "/tmp/ray/generated" |
There was a problem hiding this comment.
Let's reuse var from previous conditional
Signed-off-by: Mimi Liao <[email protected]>
alexeykudinkin
approved these changes
Nov 20, 2024
richardliaw
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR modifies the
setup-dev.pyscript to preserveray/serve/generatedfolder during the symlink creation process. Specifically:Related issue number
Closes #48792
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.