Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serve] small test change #48665

Merged
merged 2 commits into from
Nov 9, 2024
Merged

[serve] small test change #48665

merged 2 commits into from
Nov 9, 2024

Conversation

zcin
Copy link
Contributor

@zcin zcin commented Nov 8, 2024

Why are these changes needed?

Match for the more specific error that is raised, in this case TypeError, instead of matching for generic RayTaskError.

Signed-off-by: Cindy Zhang <[email protected]>
@zcin zcin requested review from edoakes and GeneDer November 8, 2024 23:47
@zcin zcin added the go add ONLY when ready to merge, run all tests label Nov 8, 2024
Copy link
Contributor

@GeneDer GeneDer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Signed-off-by: Cindy Zhang <[email protected]>
@zcin zcin enabled auto-merge (squash) November 8, 2024 23:59
@zcin zcin merged commit 9adfd9f into ray-project:master Nov 9, 2024
6 checks passed
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
## Why are these changes needed?

Match for the more specific error that is raised, in this case
`TypeError`, instead of matching for generic `RayTaskError`.

---------

Signed-off-by: Cindy Zhang <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
## Why are these changes needed?

Match for the more specific error that is raised, in this case
`TypeError`, instead of matching for generic `RayTaskError`.

---------

Signed-off-by: Cindy Zhang <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants