[core] [5/N] Check uv existence before installation #48632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hjiang <[email protected]>
dentiny
commented
Nov 7, 2024
| @@ -62,6 +64,28 @@ async def _install_uv( | |||
| logger.info("Installing package uv to %s", virtualenv_path) | |||
| await check_output_cmd(uv_install_cmd, logger=logger, cwd=cwd, env=pip_env) | |||
|
|
|||
| # TODO(hjiang): Add an integration test for existence check after | |||
| # PR (https://github.com/ray-project/ray/pull/48619) gets merged. | |||
There was a problem hiding this comment.
My planned way to test:
- In integration test with
ray.remotehavinguvspecified, making sure all packages correctly installed; - Call
_check_uv_existenceto make sureuvdoes exist in virtual env.
jjyao
approved these changes
Nov 8, 2024
| async def _check_uv_existence( | ||
| self, path: str, cwd: str, env: dict, logger: logging.Logger | ||
| ) -> bool: | ||
| """Check and return the existence of `uv` in system executable path.""" |
There was a problem hiding this comment.
This is checking the existence of uv inside the virtualenv we create for the runtime env right
jjyao
reviewed
Nov 8, 2024
| @@ -91,6 +93,28 @@ async def _install_uv( | |||
| logger.info("Installing package uv to %s", virtualenv_path) | |||
| await check_output_cmd(uv_install_cmd, logger=logger, cwd=cwd, env=pip_env) | |||
|
|
|||
| # TODO(hjiang): Add an integration test for existence check after | |||
| # PR (https://github.com/ray-project/ray/pull/48619) gets merged. | |||
There was a problem hiding this comment.
I just realize it's not a good way to test:
- Runtime env agent runs in a separate process, which means at integration test, I have no access to
UvProcessor - After task completion, the runtime env is deleted, so virtual env is expected to not found
Signed-off-by: dentiny <[email protected]>
Signed-off-by: dentiny <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
Signed-off-by: hjiang <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
Signed-off-by: hjiang <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks uv existence before installation, if
uvversion not specified by the users.