-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][core]Accelerator link #48609
Merged
Merged
[docs][core]Accelerator link #48609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
angelinalg
commented
Nov 6, 2024
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
pcmoritz
reviewed
Nov 6, 2024
@@ -4,7 +4,7 @@ | |||
Accelerator Support | |||
=================== | |||
|
|||
Accelerators (e.g. GPUs) are critical for many machine learning applications. | |||
Accelerators like GPUs are critical for many machine learning apps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"machine learning workloads" would be the better term here than "machine learning apps" I think :)
Since these are things like training, finetuning, serving, which are more like workloads than apps
jjyao
approved these changes
Nov 6, 2024
angelinalg
added
docs
An issue or change related to documentation
core
Issues that should be addressed in Ray Core
labels
Nov 6, 2024
angelinalg
added a commit
that referenced
this pull request
Nov 7, 2024
Follow up to comment in #48609 that came in after the PR merged. cc: @pcmoritz Signed-off-by: angelinalg <[email protected]> Signed-off-by: angelinalg <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
We mention `ray.util.accelerators` but we don't link to where the types are. Also fixed some style nits. Fixes https://github.com/anyscale/product/issues/31264 --------- Signed-off-by: angelinalg <[email protected]> Signed-off-by: angelinalg <[email protected]>
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…48613) Follow up to comment in ray-project#48609 that came in after the PR merged. cc: @pcmoritz Signed-off-by: angelinalg <[email protected]> Signed-off-by: angelinalg <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
We mention `ray.util.accelerators` but we don't link to where the types are. Also fixed some style nits. Fixes https://github.com/anyscale/product/issues/31264 --------- Signed-off-by: angelinalg <[email protected]> Signed-off-by: angelinalg <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…48613) Follow up to comment in ray-project#48609 that came in after the PR merged. cc: @pcmoritz Signed-off-by: angelinalg <[email protected]> Signed-off-by: angelinalg <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mention
ray.util.accelerators
but we don't link to where the types are. Also fixed some style nits.Fixes https://github.com/anyscale/product/issues/31264