Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][core]Accelerator link #48609

Merged
merged 14 commits into from
Nov 6, 2024
Merged

Conversation

angelinalg
Copy link
Contributor

@angelinalg angelinalg commented Nov 6, 2024

We mention ray.util.accelerators but we don't link to where the types are. Also fixed some style nits.

Fixes https://github.com/anyscale/product/issues/31264

@angelinalg angelinalg requested a review from a team as a code owner November 6, 2024 20:42
doc/source/ray-core/accelerator-types.rst Outdated Show resolved Hide resolved
doc/source/ray-core/accelerator-types.rst Outdated Show resolved Hide resolved
doc/source/ray-core/accelerator-types.rst Outdated Show resolved Hide resolved
doc/source/ray-core/accelerator-types.rst Outdated Show resolved Hide resolved
@@ -4,7 +4,7 @@
Accelerator Support
===================

Accelerators (e.g. GPUs) are critical for many machine learning applications.
Accelerators like GPUs are critical for many machine learning apps.
Copy link
Contributor

@pcmoritz pcmoritz Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"machine learning workloads" would be the better term here than "machine learning apps" I think :)

Since these are things like training, finetuning, serving, which are more like workloads than apps

@angelinalg angelinalg enabled auto-merge (squash) November 6, 2024 20:49
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Nov 6, 2024
@aslonnie aslonnie merged commit bac8791 into ray-project:master Nov 6, 2024
7 checks passed
@angelinalg angelinalg deleted the accelerator-link branch November 6, 2024 22:17
@angelinalg angelinalg added docs An issue or change related to documentation core Issues that should be addressed in Ray Core labels Nov 6, 2024
angelinalg added a commit that referenced this pull request Nov 7, 2024
Follow up to comment in #48609
that came in after the PR merged. cc: @pcmoritz

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
We mention `ray.util.accelerators` but we don't link to where the types
are. Also fixed some style nits.

Fixes https://github.com/anyscale/product/issues/31264

---------

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
JP-sDEV pushed a commit to JP-sDEV/ray that referenced this pull request Nov 14, 2024
…48613)

Follow up to comment in ray-project#48609
that came in after the PR merged. cc: @pcmoritz

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
We mention `ray.util.accelerators` but we don't link to where the types
are. Also fixed some style nits.

Fixes https://github.com/anyscale/product/issues/31264

---------

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
mohitjain2504 pushed a commit to mohitjain2504/ray that referenced this pull request Nov 15, 2024
…48613)

Follow up to comment in ray-project#48609
that came in after the PR merged. cc: @pcmoritz

Signed-off-by: angelinalg <[email protected]>
Signed-off-by: angelinalg <[email protected]>
Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core docs An issue or change related to documentation go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants