[Core] Rename ClientFactoryFn to CoreWorkerClientFactoryFn #48576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <[email protected]>
This reverts commit ab11d33.
Signed-off-by: Jiajun Yao <[email protected]>
jjyao
changed the title
dayshah
approved these changes
Nov 7, 2024
dentiny
reviewed
Nov 8, 2024
|
|
||
| absl::Mutex mu_; | ||
|
|
||
| struct CoreWorkerClientEntry { | ||
| public: | ||
| CoreWorkerClientEntry() {} | ||
| CoreWorkerClientEntry(ray::WorkerID worker_id, | ||
| shared_ptr<CoreWorkerClientInterface> core_worker_client) | ||
| std::shared_ptr<CoreWorkerClientInterface> core_worker_client) |
There was a problem hiding this comment.
Will fix in my next PR
dentiny
reviewed
Nov 8, 2024
| @@ -35,13 +32,13 @@ class CoreWorkerClientPool { | |||
| : client_factory_(defaultClientFactory(ccm)){}; | |||
|
|
|||
| /// Creates a CoreWorkerClientPool by a given connection function. | |||
| CoreWorkerClientPool(ClientFactoryFn client_factory) | |||
| CoreWorkerClientPool(CoreWorkerClientFactoryFn client_factory) | |||
There was a problem hiding this comment.
explicit and move semantics
There was a problem hiding this comment.
Will fix in my next PR
dentiny
reviewed
Nov 8, 2024
| @@ -20,9 +20,6 @@ | |||
| #include "ray/common/id.h" | |||
| #include "ray/rpc/worker/core_worker_client.h" | |||
|
|
|||
| using absl::optional; | |||
dentiny
approved these changes
Nov 8, 2024
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…ct#48576) Signed-off-by: Jiajun Yao <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…ct#48576) Signed-off-by: Jiajun Yao <[email protected]> Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Make it clear that it's about core worker client, not raylet client or gcs client.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.