[core][compiled-graph] Throw an exception when DAGNode is inside any type of container as a DAGNode arg #48302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
kevin85421
changed the title
kevin85421
commented
Oct 29, 2024
|
|
||
| # UUID that is not changed over copies of this node. | ||
| self._stable_uuid = uuid.uuid4().hex | ||
|
|
There was a problem hiding this comment.
I've decided to move this function below _stable_uuid so that it won't throw an error when printing self in the exception in _collect_upstream_nodes.
8 tasks
rkooo567
approved these changes
Oct 29, 2024
| actor.echo.bind((inp,)) | ||
| assert re.search(self.regex, str(exc_info.value), re.DOTALL) | ||
|
|
||
| def test_dag_node_in_dict(self, ray_start_regular): |
There was a problem hiding this comment.
is it working if dag node is in a different class?
|
This PR is a breaking change for traditional DAG. For example: ray/python/ray/dag/tests/test_function_dag.py Lines 160 to 168 in c7263e4 The test passes a dict of refs to the Should we "Throw an exception when DAGNode is inside any type of container as a DAGNode arg" only when it is a RayCG instead of making a breaking change? |
|
yeah can we make it ray cg only? |
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
ruisearch42
approved these changes
Nov 7, 2024
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
rkooo567
approved these changes
Nov 7, 2024
JP-sDEV
pushed a commit
to JP-sDEV/ray
that referenced
this pull request
Nov 14, 2024
…type of container as a DAGNode arg (ray-project#48302) Based on ray-project#48045, we have decided to treat a case where a DAGNode is inside any type of container as a DAGNode argument as an error and throw an exception. Signed-off-by: JP-sDEV <[email protected]>
mohitjain2504
pushed a commit
to mohitjain2504/ray
that referenced
this pull request
Nov 15, 2024
…type of container as a DAGNode arg (ray-project#48302) Based on ray-project#48045, we have decided to treat a case where a DAGNode is inside any type of container as a DAGNode argument as an error and throw an exception. Signed-off-by: mohitjain2504 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Based on #48045, we have decided to treat a case where a
DAGNodeis inside any type of container as aDAGNodeargument as an error and throw an exception.We verify whether there is a case in the constructor of the DAGNode.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.